|Summary:||REGRESSION (WebKit2): Input methods are active in non-editable content|
|Product:||WebKit||Reporter:||Alexey Proskuryakov <ap>|
|Component:||HTML Editing||Assignee:||Alexey Proskuryakov <ap>|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.6|
Description Alexey Proskuryakov 2011-04-12 17:30:02 PDT
Steps to reproduce: 1. Open any Web page. 2. Enable Kotoeri Hiragana (or any other input source that uses inline input) 3. Press any alphanimeric key when selection is in non-editable content. 4. Press F11. Expected results: Expose is invoked. Actual results: it's not. We should return nil from -[WKView inputContext] when the current selection is not editable.
Comment 2 Alexey Proskuryakov 2011-04-12 17:37:27 PDT
Created attachment 89317 [details] proposed fix Note that WK1 also calls -[NSApp updateWindows] to make sure that AppKit fetches the most up to date context. It's tricky to do, and I couldn't see any problems from not doing it on 10.6, so let's start without updateWindows calls to see if anything breaks.
Comment 3 Oliver Hunt 2011-04-12 17:41:06 PDT
Comment on attachment 89317 [details] proposed fix Is there a bug for the windows equivalent of this?
Comment 4 Enrica Casucci 2011-04-12 17:42:48 PDT
Comment on attachment 89317 [details] proposed fix The change looks good to me
Comment 5 Alexey Proskuryakov 2011-04-12 17:54:05 PDT
Comment on attachment 89317 [details] proposed fix I don't know if there is a Windows equivalent, I don't remember how Windows IM works.
Comment 6 WebKit Commit Bot 2011-04-12 21:35:50 PDT
Comment on attachment 89317 [details] proposed fix Clearing flags on attachment: 89317 Committed r83697: <http://trac.webkit.org/changeset/83697>
Comment 7 WebKit Commit Bot 2011-04-12 21:35:58 PDT
All reviewed patches have been landed. Closing bug.