Summary: | REGRESSION (WebKit2): Input methods are active in non-editable content | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | HTML Editing | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, enrica | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.6 | ||||||
Attachments: |
|
Description
Alexey Proskuryakov
2011-04-12 17:30:02 PDT
Created attachment 89317 [details]
proposed fix
Note that WK1 also calls -[NSApp updateWindows] to make sure that AppKit fetches the most up to date context. It's tricky to do, and I couldn't see any problems from not doing it on 10.6, so let's start without updateWindows calls to see if anything breaks.
Comment on attachment 89317 [details]
proposed fix
Is there a bug for the windows equivalent of this?
Comment on attachment 89317 [details]
proposed fix
The change looks good to me
Comment on attachment 89317 [details]
proposed fix
I don't know if there is a Windows equivalent, I don't remember how Windows IM works.
Comment on attachment 89317 [details] proposed fix Clearing flags on attachment: 89317 Committed r83697: <http://trac.webkit.org/changeset/83697> All reviewed patches have been landed. Closing bug. |