Bug 58396 – [Qt] http/tests/misc/favicon-loads-with-icon-loading-override.html fails

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Csaba Osztrogonác]

http/tests/misc/favicon-loads-with-icon-loading-override.html introduced 
in http://trac.webkit.org/changeset/83628 and fails:

http://build.webkit.org/results/Qt%20Linux%20Release/r83631%20%2831279%29/http/tests/misc/favicon-loads-with-icon-loading-override-pretty-diff.html

[Alice Liu]

looking...

[Alice Liu]

For Webkit on mac and windows, the siteicon loading preference maps to "WebKitLoadSiteIconsKey", which is defined in WebPreferenceKeysPrivate.h.  

Another example is the automatic image loading preference, which maps to "WebKitDisplayImagesKey" on mac and windows.  On qt, i don't know/see where this preference gets mapped to key.   I don't see it in qwebsettings.cpp

I'm assuming that somewhere in qt there is a preference key mapping, because otherwise layoutTestController. overridePreference() wouldn't work for any preference.  Another question i have is: if the preference keys aren't cross-platform, how are any tests that override preference expected to work cross-platform?

[Csaba Osztrogonác]

I added it to the Skipped list: http://trac.webkit.org/changeset/83670,
because it seems we should add WebKitLoadSiteIconsKey somewhere to Qt
layouttestcontroller.

[Csaba Osztrogonác]

(In reply to comment #2)
> For Webkit on mac and windows, the siteicon loading preference maps to "WebKitLoadSiteIconsKey", which is defined in WebPreferenceKeysPrivate.h.  
> 
> Another example is the automatic image loading preference, which maps to "WebKitDisplayImagesKey" on mac and windows.  On qt, i don't know/see where this preference gets mapped to key.   I don't see it in qwebsettings.cpp
> 
> I'm assuming that somewhere in qt there is a preference key mapping, because otherwise layoutTestController. overridePreference() wouldn't work for any preference.  Another question i have is: if the preference keys aren't cross-platform, how are any tests that override preference expected to work cross-platform?

Thanks for your help, we will check it. But it's too late for me now. (2:22 am)

[Alice Liu]

Created attachment 89320 [details]
patch

I think that'll fix it, but I can't be sure.  If more tweaks need to be added then feel free to take the patch and change it. No need to wait for me.

[Alice Liu]

oh and if that does fix the issue then the skipped list addition could be removed as well.

[Tor Arne Vestbø]

Comment on attachment 89320 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89320&action=review

> Source/WebKit/qt/Api/qwebsettings.h:81
> +        LoadSiteIcons

The preference is only applicable if AutoLoadImages has been disabled, and the enum name should reflect that. AlwaysLoadSiteIcons perhaps?

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.