Bug 5839

Summary: Close the 19,000+ leaks introduced during the DOM merger
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Closes leaks from the DOM merger, adds back resource dumping, etc. mjs: review+

Eric Seidel (no email)
Reported 2005-11-26 15:10:54 PST
Close the 19,000+ leaks introduced during the DOM merger The attach patch closes all known leaks in WebKit+SVG.
Attachments
Closes leaks from the DOM merger, adds back resource dumping, etc. (62.01 KB, patch)
2005-11-26 15:35 PST, Eric Seidel (no email) 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2005-11-26 15:11:05 PST
The patch also includes a (necessary) optimization to KCanvasContainer::paint() and (RenderPath::paint()) to not push a new KRenderingDeviceContext onto the context stack if one has already been pushed. Not adding this optimization was causing CGContextBeginTransparency layer to have kittens... I was never able to fully understand why, except that the transparency layer methods, as part of their silent context swapping, seem to assume a certain CGContextRef, CGContextRelease pattern which we don't seem to follow, even though my previous code seemed perfectly legal.
Eric Seidel (no email)
Comment 2 2005-11-26 15:35:50 PST
Created attachment 4811 [details] Closes leaks from the DOM merger, adds back resource dumping, etc.
Maciej Stachowiak
Comment 3 2005-11-27 02:06:11 PST
Comment on attachment 4811 [details] Closes leaks from the DOM merger, adds back resource dumping, etc. __sharedRenderingDevice Please remove the underscores from this, identifiers w/ two leading underscores are reserved to the implementation. Other than that r=me
Note You need to log in before you can comment on or make changes to this bug.