Bug 58384

Summary: Update kill-old-processes to include a few new processes
Product: WebKit Reporter: Lucas Forschler <lforschler>
Component: Tools / TestsAssignee: Lucas Forschler <lforschler>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
update the kill-old-processes script none

Lucas Forschler
Reported 2011-04-12 15:43:07 PDT
Currently the kill-old-processes does not kill Safari.exe devenv.com others? update the tool to catch these.
Attachments
update the kill-old-processes script (1.70 KB, patch)
2011-04-12 16:04 PDT, Lucas Forschler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-04-12 15:47:06 PDT
WebKitTestRunner.exe WebKit2WebProcess.exe
Adam Roben (:aroben)
Comment 2 2011-04-12 15:48:01 PDT
I guess those are already on there!
Lucas Forschler
Comment 3 2011-04-12 16:04:27 PDT
Created attachment 89295 [details] update the kill-old-processes script Add VCBuildHelper.exe, Safari.exe, and devenv.com to the list.
Adam Roben (:aroben)
Comment 4 2011-04-13 05:49:49 PDT
Comment on attachment 89295 [details] update the kill-old-processes script A followup patch to sort the list of tasks would be great.
Lucas Forschler
Comment 5 2011-04-13 05:52:21 PDT
Also, I think we should add the /T parameter to taskkill. This will kill any CHILD processes that were created by the parent.
WebKit Commit Bot
Comment 6 2011-04-13 07:28:43 PDT
Comment on attachment 89295 [details] update the kill-old-processes script Clearing flags on attachment: 89295 Committed r83732: <http://trac.webkit.org/changeset/83732>
WebKit Commit Bot
Comment 7 2011-04-13 07:28:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.