Summary: | Set minimum priority for fast lane connections | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pratik Solanki <psolanki> | ||||
Component: | Platform | Assignee: | Pratik Solanki <psolanki> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, ddkilzer, psolanki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Pratik Solanki
2011-04-12 11:42:27 PDT
eh.. allow scripts, not images. Created attachment 89240 [details]
Patch
+ * wtf/Platform.h: Define BUILDING_ON_IOS. This is strange. When is one expected to use this? Comment on attachment 89240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89240&action=review r=me > Source/JavaScriptCore/wtf/Platform.h:404 >#if OS(DARWIN) && ((defined(TARGET_OS_EMBEDDED) && TARGET_OS_EMBEDDED) \ > || (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) \ > || (defined(TARGET_IPHONE_SIMULATOR) && TARGET_IPHONE_SIMULATOR)) > #define WTF_OS_IOS 1 > +#define BUILDING_ON_IOS 1 As I just found out: TARGET_OS_IPHONE is set to "1" for both iOS hardware and iOS Simulator builds, so just checking that would be sufficient. We don't need to check for TARGET_OS_EMBEDDED or TARGET_IPHONE_SIMULATOR here. If you want to clean up the definition for WTF_PLATFORM_IOS and WTF_PLATFORM_IOS_SIMULATOR below at the same time, that would be great, but not necessary. WTF_PLATFORM_IOS only needs to check for TARGET_OS_IPHONE being 1, and WTF_PLATFORM_IOS_SIMULATOR only needs to check for TARGET_IPHONE_SIMULATOR being 1. (In reply to comment #4) > + * wtf/Platform.h: Define BUILDING_ON_IOS. > > This is strange. When is one expected to use this? This could be used with other BUILDING_ON_MACOSX_KITTY macros, or would it be better to use PLATFORM(IOS) there instead since the BUILDING_ON_FOO macros are only for checking versions? Comment on attachment 89240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89240&action=review >> Source/JavaScriptCore/wtf/Platform.h:404 >> +#define BUILDING_ON_IOS 1 > > As I just found out: > > TARGET_OS_IPHONE is set to "1" for both iOS hardware and iOS Simulator builds, so just checking that would be sufficient. We don't need to check for TARGET_OS_EMBEDDED or TARGET_IPHONE_SIMULATOR here. > > If you want to clean up the definition for WTF_PLATFORM_IOS and WTF_PLATFORM_IOS_SIMULATOR below at the same time, that would be great, but not necessary. > > WTF_PLATFORM_IOS only needs to check for TARGET_OS_IPHONE being 1, and WTF_PLATFORM_IOS_SIMULATOR only needs to check for TARGET_IPHONE_SIMULATOR being 1. Since iOS isn't self-hosting, "BUILDING_ON_IOS" doesn't make much sense here. Probably best to just use the existing PLATFORM(IOS) instead. Committed r83882: <http://trac.webkit.org/changeset/83882> |