Bug 58348

Summary:

commit-queue should upload failure diffs when tests fail

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dbates, jamesr

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	abarth: review+

Eric Seidel (no email)

Reported 2011-04-12 10:43:07 PDT

commit-queue should upload failure diffs when tests fail I get several requests a week for people wanting to see the results from their failures. Best to just make it automatic.

Attachments
Patch (17.50 KB, patch) 2011-04-12 10:47 PDT, Eric Seidel (no email)	abarth: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2011-04-12 10:43:33 PDT

*** Bug 46685 has been marked as a duplicate of this bug. ***

Eric Seidel (no email)

Comment 2 2011-04-12 10:47:02 PDT

Created attachment 89226 [details] Patch

Adam Barth

Comment 3 2011-04-12 10:52:50 PDT

Comment on attachment 89226 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89226&action=review > Tools/Scripts/webkitpy/tool/commands/queues.py:-54 > - We probably should keep this line, right? > Tools/Scripts/webkitpy/tool/commands/queues.py:263 > + bot_id = self._tool.status_server.bot_id or "bot" self.name instead of "bot" ? > Tools/Scripts/webkitpy/tool/commands/queues.py:270 > + comment_text = "The attached test failures were seen while running run-webkit-tests on the %s.\n" % (self.name) No () needed.

Eric Seidel (no email)

Comment 4 2011-04-12 11:05:14 PDT

Comment on attachment 89226 [details] Patch I'm running it locally for a bit first.

Eric Seidel (no email)

Comment 5 2011-04-12 11:21:45 PDT

Comment on attachment 89226 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89226&action=review >> Tools/Scripts/webkitpy/tool/commands/queues.py:263 >> + bot_id = self._tool.status_server.bot_id or "bot" > > self.name instead of "bot" ? I guess. it's not really a bot id. But you could argue that file name should include commit-queue instead of id of the cq bot in question. This currently matches what the flaky test reporting does. >> Tools/Scripts/webkitpy/tool/commands/queues.py:270 >> + comment_text = "The attached test failures were seen while running run-webkit-tests on the %s.\n" % (self.name) > > No () needed. True. I don't know what pep8 says about this. I generally include them for consistency.

Eric Seidel (no email)

Comment 6 2011-04-12 11:30:28 PDT

Committed r83614: <http://trac.webkit.org/changeset/83614>

Note You need to log in before you can comment on or make changes to this bug.