Bug 58304 – REGRESSION: WK2: misspelled AX attributes no longer returned from text fields

• Component: Accessibility
• Status: RESOLVED FIXED

[chris fleizach]

When typing in to an edit field,VoiceOver does not announce the presence of a mis-spelled word with the announcement "mis-spelled" followed by the mis-spelled word.

[chris fleizach]

rdar://9258679

[chris fleizach]

Created attachment 89169 [details]
patch

Comment on attachment 89169 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89169&action=review

> Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm:491
> +    unsigned size = results.size();
> +    for (unsigned i = 0; i < size; i++) {

Please use size_t for a Vector’s size and the loop variable.

> Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm:492
> +        const TextCheckingResult* result = &results[i];

A more natural way to do this in C++ would be
    const TextCheckingResult& result = results[i];

> Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm:493
> +        AXAttributeStringSetNumber(attrString, NSAccessibilityMisspelledTextAttribute, [NSNumber numberWithBool:YES], NSMakeRange(result->location + range.location, result->length));

Allocating and autoreleasing an NSNumber each time through the loop is not so great, but no worse than what the old code did.

[chris fleizach]

http://trac.webkit.org/changeset/83589

[chris fleizach]

broke leopard mac because checkParagraph is not available there

[chris fleizach]

will fix now

[chris fleizach]

http://trac.webkit.org/changeset/83609 to fix the leopard build