Summary: | Provide new setting to allow site icon loading despite disabling automatic image loading in general. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alice Liu <alice.barraclough> | ||||||||
Component: | WebKit API | Assignee: | Alice Liu <alice.barraclough> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Alice Liu
2011-04-11 17:38:23 PDT
Created attachment 89135 [details]
patch
Attachment 89135 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1
Source/WebKit/win/WebPreferences.cpp:930: Extra space after ( in function call [whitespace/parens] [4]
Source/WebKit/win/WebPreferences.cpp:937: Extra space after ( in function call [whitespace/parens] [4]
Source/WebKit/win/WebPreferences.h:178: Extra space after ( in function call [whitespace/parens] [4]
Source/WebKit/win/WebPreferences.h:181: Extra space after ( in function call [whitespace/parens] [4]
Total errors found: 4 in 26 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 89136 [details]
patch - fixed whitespace bot complaints
Attachment 89136 [details] did not build on win: Build output: http://queues.webkit.org/results/8391204 Comment on attachment 89136 [details] patch - fixed whitespace bot complaints View in context: https://bugs.webkit.org/attachment.cgi?id=89136&action=review > Source/WebKit/mac/WebView/WebPreferences.h:338 > + @method setWillLoadSiteIconsIgnoringImageLoadingPreference: > + @param flag > +*/ > +- (void)setLoadsSiteIconsIgnoringImageLoadingPreference: (BOOL)flag; > + > +/*! > + @method willLoadSiteIconsIgnoringImageLoadingPreference > +*/ > +- (BOOL)loadsSiteIconsIgnoringImageLoadingPreference; These have not gone through API review, so these need to be in WebPreferencesPrivate.h Created attachment 89241 [details]
patch - moved pref to [|I]WebPreferencesPrivate.[h|idl]
Comment on attachment 89241 [details] patch - moved pref to [|I]WebPreferencesPrivate.[h|idl] View in context: https://bugs.webkit.org/attachment.cgi?id=89241&action=review > Source/WebCore/loader/FrameLoader.cpp:712 > + if (settings && !settings->loadsImagesAutomatically() && !settings->loadsSiteIconsIgnoringImageLoadingSetting()) > + return; > Looks like you added an extra space here. committed http://trac.webkit.org/changeset/83628 |