Bug 58292

Summary: Provide new setting to allow site icon loading despite disabling automatic image loading in general.
Product: WebKit Reporter: Alice Liu <alice.barraclough>
Component: WebKit APIAssignee: Alice Liu <alice.barraclough>
Severity: Normal CC: buildbot, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Description Flags
patch - fixed whitespace bot complaints
sam: review-
patch - moved pref to [|I]WebPreferencesPrivate.[h|idl] sam: review+

Description Alice Liu 2011-04-11 17:38:23 PDT
Turning off the WebCore setting for automatic image loading has the intentional side effect of disabling site icon (favicon) image loading.  It's possible that a WebView client may actually just want to turn off image loading in webpages but still want to load site icons so that the icondatabase gets populated.  I'd like to add an additional preference that is heeded only regarding the icondatabase.
Comment 1 Alice Liu 2011-04-11 18:09:19 PDT
Created attachment 89135 [details]
Comment 2 WebKit Review Bot 2011-04-11 18:11:10 PDT
Attachment 89135 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1

Source/WebKit/win/WebPreferences.cpp:930:  Extra space after ( in function call  [whitespace/parens] [4]
Source/WebKit/win/WebPreferences.cpp:937:  Extra space after ( in function call  [whitespace/parens] [4]
Source/WebKit/win/WebPreferences.h:178:  Extra space after ( in function call  [whitespace/parens] [4]
Source/WebKit/win/WebPreferences.h:181:  Extra space after ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 26 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alice Liu 2011-04-11 18:15:01 PDT
Created attachment 89136 [details]
patch - fixed whitespace bot complaints
Comment 4 Build Bot 2011-04-11 21:13:23 PDT
Attachment 89136 [details] did not build on win:
Build output: http://queues.webkit.org/results/8391204
Comment 5 Sam Weinig 2011-04-11 21:15:39 PDT
Comment on attachment 89136 [details]
patch - fixed whitespace bot complaints

View in context: https://bugs.webkit.org/attachment.cgi?id=89136&action=review

> Source/WebKit/mac/WebView/WebPreferences.h:338
> +    @method setWillLoadSiteIconsIgnoringImageLoadingPreference:
> +    @param flag
> +*/
> +- (void)setLoadsSiteIconsIgnoringImageLoadingPreference: (BOOL)flag;
> +
> +/*!
> +    @method willLoadSiteIconsIgnoringImageLoadingPreference
> +*/
> +- (BOOL)loadsSiteIconsIgnoringImageLoadingPreference;

These have not gone through API review, so these need to be in WebPreferencesPrivate.h
Comment 6 Alice Liu 2011-04-12 12:15:57 PDT
Created attachment 89241 [details]
patch - moved pref to [|I]WebPreferencesPrivate.[h|idl]
Comment 7 Sam Weinig 2011-04-12 13:06:22 PDT
Comment on attachment 89241 [details]
patch - moved pref to [|I]WebPreferencesPrivate.[h|idl]

View in context: https://bugs.webkit.org/attachment.cgi?id=89241&action=review

> Source/WebCore/loader/FrameLoader.cpp:712
> +    if (settings && !settings->loadsImagesAutomatically() && !settings->loadsSiteIconsIgnoringImageLoadingSetting())
> +         return;

Looks like you added an extra space here.
Comment 8 Alice Liu 2011-04-12 13:23:07 PDT
committed http://trac.webkit.org/changeset/83628