Bug 58276

Summary:

Prevent duplicate plug-ins from loading on Windows due to WOW64 folder redirection

Product:

WebKit

Reporter:

Steve Falkenburg <sfalken>

Component:

New Bugs

Assignee:

Steve Falkenburg <sfalken>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

aroben, jhoneycutt, webkit-ews, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

49075

Attachments:

Description	Flags
Patch	none
Patch	none

Steve Falkenburg

Reported 2011-04-11 15:22:31 PDT

Prevent duplicate plug-ins from loading on Windows

Attachments
Patch (7.35 KB, patch) 2011-04-11 15:55 PDT, Steve Falkenburg	no flags	Details Formatted Diff Diff
Patch (7.38 KB, patch) 2011-04-11 15:57 PDT, Steve Falkenburg	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Steve Falkenburg

Comment 1 2011-04-11 15:55:09 PDT

Created attachment 89110 [details] Patch

Steve Falkenburg

Comment 2 2011-04-11 15:57:16 PDT

Created attachment 89111 [details] Patch

WebKit Review Bot

Comment 3 2011-04-11 16:00:19 PDT

Attachment 89110 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 4 2011-04-11 16:00:59 PDT

Attachment 89111 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 5 2011-04-11 16:17:05 PDT

Attachment 89111 [details] did not build on qt: Build output: http://queues.webkit.org/results/8390090

Adam Roben (:aroben)

Comment 6 2011-04-12 05:05:07 PDT

You are really good at filing duplicates of bugs I filed months ago. :-) *** This bug has been marked as a duplicate of bug 49075 ***

Adam Roben (:aroben)

Comment 7 2011-04-12 05:08:52 PDT

Hm, I guess your fix is a bit more specific than bug 49075 describes. I've updated the title to be more specific. I think this should probably be implemented in PluginInfoStore::shouldUsePlugin. That's where Mac makes sure that only one plugin with a given bundle identifier gets loaded, e.g.

Adam Roben (:aroben)

Comment 8 2011-04-12 05:11:23 PDT

Actually, I think maybe this is in fact a dupe of bug 49075 after all. The plan in that bug is to prevent two plugins with the same filename from being loaded. WebCore already has this behavior. That would fix this bug, too, I think (and be quite a bit simpler). *** This bug has been marked as a duplicate of bug 49075 ***

Eric Seidel (no email)

Comment 9 2011-04-18 09:16:55 PDT

Comment on attachment 89111 [details] Patch Cleared review? from attachment 89111 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).

Note You need to log in before you can comment on or make changes to this bug.