Summary: | Ignore context change callbacks when not on the main thread | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
Component: | Layout and Rendering | Assignee: | Eric Carlson <eric.carlson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | Windows 7 | ||||||
Attachments: |
|
Description
Eric Carlson
2011-04-11 12:16:00 PDT
Created attachment 89051 [details]
Proposed patch
It would be nice to have a little more information in the bug and ChangeLog about when this could happen and why it's OK to ignore the callback in that case. It is safe to ignore the contextDidChangeCallback callback from background threads because in that case no changes have actually been committed to the context, so there is no chance animations will have started, etc. Thanks, Eric. To be even more specific, IIRC, we expect to receive this notification on a background thread due to a CAImageQueue being modified. But in that case, as Eric said, there are no real changes to the context; we just need to render again (which WKCACFView will take care of on its own). Eric, I think WebKit2 needs the same fix applied in LayerTreeHostCAWin. http://trac.webkit.org/changeset/83497 for the WK1 part. http://trac.webkit.org/changeset/83508 for the WK2 portion. |