Bug 58192
| Summary: | new-run-webkit-tests: Mac SL tests failing on the bot | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> |
| Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aroben |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.6 | ||
Dirk Pranke
There's a set of tests failing on the NRWT bot that need to be triaged to see if they are normal regressions, tests that are failing because of the bot config, tests failing because of NRWT, or because of multi-process NRWT.
Here's the initial list as of r83372
// Failing
fast/loader/local-CSS-from-local.html = TEXT
fast/loader/local-JavaScript-from-local.html = TEXT
fast/loader/local-image-from-local.html = TEXT
fast/text/international/bold-bengali.html = TEXT
fast/text/international/khmer-selection.html = TEXT
http/tests/security/local-user-CSS-from-remote.html = TEXT
plugins/npp-set-window-called-during-destruction.html = TEXT
// Flaky tests when run multi-process
fast/dom/frame-loading-via-document-write.html = TEXT PASS
http/tests/appcache/fail-on-update-2.html = TEXT PASS
http/tests/appcache/fail-on-update.html = TEXT PASS
http/tests/inspector/console-websocket-error.html = TEXT PASS
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Dirk Pranke
More flakiness:
fast/canvas/webgl/gl-teximage.html = TEXT PASS
fast/frames/flattening/iframe-flattening-offscreen.html = TEXT PASS
svg/dom/SVGScriptElement/script-set-href.svg = TEXT PASS
Dirk Pranke
Committed r83383: <http://trac.webkit.org/changeset/83383>
Adam Roben (:aroben)
(In reply to comment #0)
> plugins/npp-set-window-called-during-destruction.html = TEXT
ORWT has special-case code to skip this test on 64-bit SnowLeopard or newer with WebKit1. See <http://trac.webkit.org/changeset/83300>.
Dirk Pranke
(In reply to comment #3)
> (In reply to comment #0)
> > plugins/npp-set-window-called-during-destruction.html = TEXT
>
> ORWT has special-case code to skip this test on 64-bit SnowLeopard or newer with WebKit1. See <http://trac.webkit.org/changeset/83300>.
NRWT can handle this with the proper suppression in the expectations file, but I need to know if it's just 64-bit, or both. From the bug description, it sounds like it's the out-of-process part that causes it to fail, and I assume the plugins are out-of-process regardless of the architecture? Or are they only out-of-process because the binary is 64-bit?
Adam Roben (:aroben)
Plugins are only out-of-process in 64-bit builds.
Dirk Pranke
(In reply to comment #5)
> Plugins are only out-of-process in 64-bit builds.
Okay. Do you even test 32-bit builds on SL, or is it safe to suppress the test regardless of the architecture?
Adam Roben (:aroben)
It's certainly possible to build and test a 32-bit build on SnowLeopard. We don't have any bots that do it. But developers can do it quite easily (using set-webkit-configuration --32-bit).
Dirk Pranke
(In reply to comment #7)
> It's certainly possible to build and test a 32-bit build on SnowLeopard. We don't have any bots that do it. But developers can do it quite easily (using set-webkit-configuration --32-bit).
Okay, I'll just mark the failure for SL generically and add a comment. Right now we don't have any other SL failures that are 32/64-bit specific and the NRWT python code doesn't attempt to figure which architecture is which. I'll refrain from adding that until it's really necessary.