Bug 58170
| Summary: | Remove old (now obsolete) comments carried over from CanvasSurface | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Matthew Delaney <mdelaney7> |
| Component: | Platform | Assignee: | Matt Woodrow <mattwoodrow> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, heycam, jamesr, levin, mattwoodrow, mmaxfield, rniwa |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Matthew Delaney
I found this:
"
// FIXME: Make isSupportedImageMIMETypeForEncoding threadsafe (to allow this method to be used on a worker thread).
"
...in HTMLCanvasElement.cpp and couldn't find any bugs for it, so here it is.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
James Robinson
I thought we abandoned plans for canvas from works a while back?
James Robinson
(In reply to comment #1)
> I thought we abandoned plans for canvas from works a while back?
from _workers_ that is. I think Dave Levin was working on this most recently (about a year ago).
Matthew Delaney
I don't know, svn blame tells me that these FIXME lines were added by you (in a distant revision). Perhaps check and remove anything that's old?
James Robinson
Blame implicates me because I moved those lines from CanvasSurface, which was intended to be infrastructure for supporting canvas from workers:
http://trac.webkit.org/changeset/63025
I think the FIXME was originally added by this checkin:
http://trac.webkit.org/changeset/56447
but since that work is (afaik) dead it's probably safe to remove the FIXME now.
Matthew Delaney
Gotcha. I'll update the bug name to reflect that then.
David Levin
(In reply to comment #4)
> but since that work is (afaik) dead it's probably safe to remove the FIXME now.
Yep, my doing (originally) and it can be removed.
Ahmad Saleem
@mmaxfield@apple.com - I think you work on offscreenCanvas API to move things to worker would also address this?
Myles C. Maxfield
Matt is working on that.