Bug 58159

Summary: dump-as-markup conversion: editing/pasteboard/paste-xml.xhtml
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 58158    
Attachments:
Description Flags
Patch
none
Converted to a text dump.
none
Patch
none
Patch none

Ryosuke Niwa
Reported 2011-04-08 13:30:52 PDT
To further investigate the bug 58158, we should make editing/pasteboard/paste-xml.xhtml a dump-as-markup test so the output can easily be understood.
Attachments
Patch (25.17 KB, patch)
2011-06-10 14:17 PDT, Wyatt Carss 		no flags
DetailsFormatted DiffDiff
Converted to a text dump. (18.66 KB, patch)
2011-06-10 15:19 PDT, Wyatt Carss 		no flags
DetailsFormatted DiffDiff
Patch (18.72 KB, patch)
2011-06-10 16:06 PDT, Wyatt Carss 		no flags
DetailsFormatted DiffDiff
Patch (18.79 KB, patch)
2011-06-10 16:10 PDT, Wyatt Carss 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Wyatt Carss
Comment 1 2011-06-10 14:17:52 PDT
Created attachment 96784 [details] Patch
Ryosuke Niwa
Comment 2 2011-06-10 14:21:27 PDT
Comment on attachment 96784 [details] Patch We shouldn't be dumping the whole page for this test. I bet you can just call runDumpAsTextEditingTest instead of runEditingTest.
Wyatt Carss
Comment 3 2011-06-10 15:19:56 PDT
Created attachment 96802 [details] Converted to a text dump.
Ryosuke Niwa
Comment 4 2011-06-10 15:30:22 PDT
Comment on attachment 96802 [details] Converted to a text dump. View in context: https://bugs.webkit.org/attachment.cgi?id=96802&action=review Are you speculatively changing expected.txt for all platforms? I don't think that'll work. I suggest you delete all platform-specific results and add platform-independent result in editing/pasteboard/paste-xml.xhtml. You can then add platform-specific results for each port on which the test fails. > LayoutTests/platform/chromium/test_expectations.txt:3222 > -BUGWK58158 : editing/pasteboard/paste-xml.xhtml = PASS TEXT > +BUGWK58158 : editing/pasteboard/paste-xml.xhtml = PASS You should remove this entry if the test really passes.
Wyatt Carss
Comment 5 2011-06-10 16:06:13 PDT
Created attachment 96817 [details] Patch
Wyatt Carss
Comment 6 2011-06-10 16:10:41 PDT
Created attachment 96819 [details] Patch
Ryosuke Niwa
Comment 7 2011-06-10 16:12:22 PDT
Comment on attachment 96819 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96819&action=review > LayoutTests/platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt:18 > +foo barbar baz I would have loved to add a test description here but it's fine as is.
Ryosuke Niwa
Comment 8 2011-06-13 14:04:33 PDT
Who is landing this patch?
Wyatt Carss
Comment 9 2011-06-13 15:14:58 PDT
Comment on attachment 96819 [details] Patch Requesting commit
WebKit Review Bot
Comment 10 2011-06-13 15:37:29 PDT
Comment on attachment 96819 [details] Patch Clearing flags on attachment: 96819 Committed r88717: <http://trac.webkit.org/changeset/88717>
WebKit Review Bot
Comment 11 2011-06-13 15:37:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.