Summary: | REGRESSION: a character appears after tab span when typing immediately before the tab span | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, adele, darin, enrica, eric, justin.garcia, leviw, ojan, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
I can reproduce this in Safari 5.0.3 (In reply to comment #2) > I can reproduce this in Safari 5.0.3 I see so I guess this is a pretty old regression. It doesn't reproduce on Chrome 10 though. The rough range I found was between r 46914 and 58919. I'm having trouble bisecting right now. It appears that the problem arises because the pasted "hello" goes into the Tab Span, which we proceed to avoid trying to place any other text in when editing. Paste shouldn't place the text into the tab span and InsertTextCommand::positionInsideTextNode shouldn't assume any position in a tab span should be moved to after the tab span. Created attachment 90986 [details]
Patch
Comment on attachment 90986 [details]
Patch
r=me provided you've ran all layout tests.
Comment on attachment 90986 [details] Patch Clearing flags on attachment: 90986 Committed r84885: <http://trac.webkit.org/changeset/84885> http://trac.webkit.org/changeset/84885 might have broken SnowLeopard Intel Release (WebKit2 Tests) |
Created attachment 88793 [details] test case Reproduction steps: 1. Open the attached test case 2. Copy "hello" 3. Paste "hello" immediately after "hello" 4. Type "x" Expected result: "x" appears immediately after the second "hello" before a tab span. Actual result: "x" appears after the tab span.