Bug 58130

Summary: [EFL] Adjust dpi value to viewport computation
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kenneth, leandro, lucas.de.marchi, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Prototype Patch
none
Proposed Patch
kenneth: review+
Extended Width Page when EWebLauncher is not resized
none
Modified Patch none

Description Gyuyoung Kim 2011-04-08 03:12:36 PDT
I make a patch, which adjusts dpi to viewport computation. But, I think this patch needs to be considered further. 
I'd like to listen comments.
Comment 1 Gyuyoung Kim 2011-04-08 03:17:32 PDT
Created attachment 88790 [details]
Prototype Patch
Comment 2 Gyuyoung Kim 2011-04-11 05:15:07 PDT
Created attachment 88993 [details]
Proposed Patch

I adjust dpi value of device to viewport computation. And, I modified that EWebLauncher is also changed by the viewport's width / height.
Comment 3 Kenneth Rohde Christiansen 2011-04-11 05:45:49 PDT
Comment on attachment 88993 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88993&action=review

> Tools/EWebLauncher/main.c:275
> +    ecore_evas_resize(app->ee, app->viewport.w + 20, app->viewport.h + 20);

Seems unrelated
Comment 4 Gyuyoung Kim 2011-04-11 16:22:30 PDT
(In reply to comment #3)
> (From update of attachment 88993 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88993&action=review
> 
> > Tools/EWebLauncher/main.c:275
> > +    ecore_evas_resize(app->ee, app->viewport.w + 20, app->viewport.h + 20);
> 
> Seems unrelated

If EWebLauncher size isn't changed, viewport page (e.g, mobile page) is not rendered completely. Because width and height values are changed by dpi value
Comment 5 Gyuyoung Kim 2011-04-11 16:24:08 PDT
Created attachment 89118 [details]
Extended Width Page when EWebLauncher is not resized
Comment 6 Gyuyoung Kim 2011-04-11 16:26:58 PDT
(In reply to comment #5)
> Created an attachment (id=89118) [details]
> Extended Width Page when EWebLauncher is not resized

If EWebLauncher is not resized, EWebLauncher just shows part of page. Because, width and height is changed by dpi value. As you know, computeViewportAttributes() changes the values. I think it is better to resize EWebLauncher whenever viewport value is changed. How do you think about it ?
Comment 7 Gyuyoung Kim 2011-04-11 18:47:03 PDT
Created attachment 89142 [details]
Modified Patch

When I resize EWebLauncher's size, page size and device size are changed. Thus, computed viewport width, height values are also more larger because EWebLauncher is more bigger. Eventually, viewport page is not fit to EWebLauncher. Even though there is scroll bar in viewport page, for now, I'd like to add this patch. I'm going to make better solution for this.
Comment 8 WebKit Commit Bot 2011-04-11 20:41:26 PDT
Comment on attachment 89142 [details]
Modified Patch

Clearing flags on attachment: 89142

Committed r83553: <http://trac.webkit.org/changeset/83553>