Bug 58080

Summary: Make IconSnapshot and PageURLRecord member variables private.
Product: WebKit Reporter: David Levin <levin>
Component: Page LoadingAssignee: David Levin <levin>
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Patch darin: review+

Description David Levin 2011-04-07 14:27:11 PDT
This helps to ensure that they are only modified in given ways and in general is a good C++ practice.
Comment 1 David Levin 2011-04-07 14:31:00 PDT
Created attachment 88699 [details]
Comment 2 Darin Adler 2011-04-07 16:21:24 PDT
Comment on attachment 88699 [details]

Since we never want to change these after creating them, seems like a reasonable way to go. The other direction would be to make them structs.
Comment 3 David Levin 2011-04-07 17:56:30 PDT
Committed as http://trac.webkit.org/changeset/83234
Comment 4 WebKit Review Bot 2011-04-07 18:44:17 PDT
http://trac.webkit.org/changeset/83234 might have broken Qt Linux Release
The following tests are not passing: