Bug 58076

Summary: [Qt] Regression : r83051 Oxygen's lineedits are not rendered properly
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: WebKit QtAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Blocker CC: commit-queue, diegohcg, kenneth
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Proposed patch.
kling: review-
V2 with comments taken into account. none

Description Alexis Menard (darktears) 2011-04-07 13:43:42 PDT
Go to bugs.webkit.org, all lineedits are invisible. This does not happen with Plastique style. Clicking on them make them appear.
Comment 1 Alexis Menard (darktears) 2011-04-08 04:20:24 PDT
r83051 broke it.
Comment 2 Alexis Menard (darktears) 2011-04-08 05:35:18 PDT
Created attachment 88804 [details]
Proposed patch.

I'm not sure how this patch align with the mobile theme but it fixes the bad issue with Oxygen.
Comment 3 Diego Gonzalez 2011-04-08 07:41:46 PDT
(In reply to comment #2)
> Created an attachment (id=88804) [details]
> Proposed patch.
> 
> I'm not sure how this patch align with the mobile theme but it fixes the bad issue with Oxygen.

I think we will need a #ifdef :(
Comment 4 Andreas Kling 2011-04-08 11:03:00 PDT
Comment on attachment 88804 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=88804&action=review

> Source/WebCore/platform/qt/RenderThemeQt.cpp:676
> -    if (isPressed(o))
> -        panel.state |= QStyle::State_Sunken;
> +    panel.state |= QStyle::State_Sunken;

Diego is right, this needs to go in an #if USE(QT_MOBILE_THEME) block ;(
Comment 5 Alexis Menard (darktears) 2011-04-11 04:54:45 PDT
Created attachment 88989 [details]
V2 with comments taken into account.
Comment 6 Andreas Kling 2011-04-11 04:58:20 PDT
Comment on attachment 88989 [details]
V2 with comments taken into account.

r=me, the Sunken state is a mess, but we can't get out of it for Qt4 anyway :/
Comment 7 WebKit Commit Bot 2011-04-11 06:38:15 PDT
Comment on attachment 88989 [details]
V2 with comments taken into account.

Clearing flags on attachment: 88989

Committed r83437: <http://trac.webkit.org/changeset/83437>
Comment 8 WebKit Commit Bot 2011-04-11 06:38:22 PDT
All reviewed patches have been landed.  Closing bug.