Summary: | [Qt] Regression : r83051 Oxygen's lineedits are not rendered properly | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexis Menard (darktears) <menard> | ||||||
Component: | WebKit Qt | Assignee: | Alexis Menard (darktears) <menard> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Blocker | CC: | commit-queue, diegohcg, kenneth | ||||||
Priority: | P1 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Alexis Menard (darktears)
2011-04-07 13:43:42 PDT
Created attachment 88804 [details]
Proposed patch.
I'm not sure how this patch align with the mobile theme but it fixes the bad issue with Oxygen.
(In reply to comment #2) > Created an attachment (id=88804) [details] > Proposed patch. > > I'm not sure how this patch align with the mobile theme but it fixes the bad issue with Oxygen. I think we will need a #ifdef :( Comment on attachment 88804 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=88804&action=review > Source/WebCore/platform/qt/RenderThemeQt.cpp:676 > - if (isPressed(o)) > - panel.state |= QStyle::State_Sunken; > + panel.state |= QStyle::State_Sunken; Diego is right, this needs to go in an #if USE(QT_MOBILE_THEME) block ;( Created attachment 88989 [details]
V2 with comments taken into account.
Comment on attachment 88989 [details]
V2 with comments taken into account.
r=me, the Sunken state is a mess, but we can't get out of it for Qt4 anyway :/
Comment on attachment 88989 [details] V2 with comments taken into account. Clearing flags on attachment: 88989 Committed r83437: <http://trac.webkit.org/changeset/83437> All reviewed patches have been landed. Closing bug. |