Bug 58076 – [Qt] Regression : r83051 Oxygen's lineedits are not rendered properly

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Alexis Menard (darktears)]

Go to bugs.webkit.org, all lineedits are invisible. This does not happen with Plastique style. Clicking on them make them appear.

[Alexis Menard (darktears)]

r83051 broke it.

[Alexis Menard (darktears)]

Created attachment 88804 [details]
Proposed patch.

I'm not sure how this patch align with the mobile theme but it fixes the bad issue with Oxygen.

[Diego Gonzalez]

(In reply to comment #2)
> Created an attachment (id=88804) [details]
> Proposed patch.
> 
> I'm not sure how this patch align with the mobile theme but it fixes the bad issue with Oxygen.

I think we will need a #ifdef :(

[Andreas Kling]

Comment on attachment 88804 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=88804&action=review

> Source/WebCore/platform/qt/RenderThemeQt.cpp:676
> -    if (isPressed(o))
> -        panel.state |= QStyle::State_Sunken;
> +    panel.state |= QStyle::State_Sunken;

Diego is right, this needs to go in an #if USE(QT_MOBILE_THEME) block ;(

[Alexis Menard (darktears)]

Created attachment 88989 [details]
V2 with comments taken into account.

[Andreas Kling]

Comment on attachment 88989 [details]
V2 with comments taken into account.

r=me, the Sunken state is a mess, but we can't get out of it for Qt4 anyway :/

[WebKit Commit Bot]

Comment on attachment 88989 [details]
V2 with comments taken into account.

Clearing flags on attachment: 88989

Committed r83437: <http://trac.webkit.org/changeset/83437>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.