Bug 58075

Summary: WebBackForwardList::createCFDictionaryRepresentation's current item index doesn't account for items removed by filter callback
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: WebKit2Assignee: Mark Rowe (bdash) <mrowe>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch mitz: review+

Mark Rowe (bdash)
Reported 2011-04-07 13:41:55 PDT
If the filter callback removes an item then the current item index will be off by one! This can cause the session state to restore to the wrong item or to fail to restore all together if the current item was the last item in the back/forward list. <rdar://problem/9251566>
Attachments
Patch (4.11 KB, patch)
2011-04-07 13:42 PDT, Mark Rowe (bdash) 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2011-04-07 13:42:17 PDT
Created attachment 88687 [details] Patch
WebKit Review Bot
Comment 2 2011-04-07 13:44:20 PDT
Attachment 88687 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Rowe (bdash)
Comment 3 2011-04-07 13:59:56 PDT
Landed in r83206.
Note You need to log in before you can comment on or make changes to this bug.