Summary: | [GTK] Unskip accessibility/input-slider.html and accessibility/media-element.html | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mario Sanchez Prada <mario> | ||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | Keywords: | Gtk | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | 58039 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Mario Sanchez Prada
2011-04-07 06:55:11 PDT
Created attachment 88627 [details]
Patch proposal + unskipped layout tests
Attaching patch proposal.
Comment on attachment 88627 [details] Patch proposal + unskipped layout tests View in context: https://bugs.webkit.org/attachment.cgi?id=88627&action=review r=me. I suspect you'd rather call accessibilityIsIgnored() than accessibilityPlatformIncludesObject() which i think should really only be called by accessibilityIsIgnored() itself > Source/WebCore/accessibility/AccessibilitySlider.cpp:99 > + if (thumb->accessibilityPlatformIncludesObject() == IgnoreObject) can you just ask accessibilityIsIgnored() here. (In reply to comment #2) > (From update of attachment 88627 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=88627&action=review > > r=me. I suspect you'd rather call accessibilityIsIgnored() than accessibilityPlatformIncludesObject() which i think should really only be called by accessibilityIsIgnored() itself > > > Source/WebCore/accessibility/AccessibilitySlider.cpp:99 > > + if (thumb->accessibilityPlatformIncludesObject() == IgnoreObject) > > can you just ask accessibilityIsIgnored() here. Problem is that currently accessibilityIsIgnored() is a private method for AXSliderThumb which always return 'false' and, even if I could change that implementation to call accessibilityIsIgnoredBase(), AXSliderThumb is a subclass of AXObject (not AXRenderObject), where that function is not defined either (accessibilityIsIgnoredBase is defined for AXRenderObject)... So that's why I directly called accessibilityPlatformIncludesObject() instead, following the lead of AccessibilityMenuList::addChildren(). However, I think I could slightly change my patch to: 1. Implement accessibilityIsIgnored() in AXSliderThumb and make it public (so I can call it from AXSlider:addChildren()) 2. Make AXSliderThumb::accessibilityIsIgnored() call accessibilityPlatformIncludesObject() from there, which is defined for AXObject. I'll make that change and propose a new patch then... Created attachment 88830 [details]
Patch proposal + unskipped layout tests
Attached new patch with the changes commented before. Asking for review again, and sorry for the hassle...
Comment on attachment 88830 [details]
Patch proposal + unskipped layout tests
thanks. r=me
Committed r83479: <http://trac.webkit.org/changeset/83479> |