Bug 58039

Summary: [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: New BugsAssignee: Mario Sanchez Prada <mario>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 58040    
Attachments:
Description Flags
Patch mrobinson: review+

Description Mario Sanchez Prada 2011-04-07 06:35:58 PDT
[GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
Comment 1 Mario Sanchez Prada 2011-04-07 06:39:44 PDT
Created attachment 88620 [details]
Patch
Comment 2 Mario Sanchez Prada 2011-04-07 06:56:40 PDT
For additional info, the motivation behind this bug is fixing bug 58040, which is about skipping two accessibility tests.
Comment 3 Martin Robinson 2011-04-07 16:51:46 PDT
Comment on attachment 88620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88620&action=review

> Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:32
>  

Please remove this extra newline.

> Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:580
> +

Ditto.

> Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:590
> +

Ditto.
Comment 4 Mario Sanchez Prada 2011-04-08 02:15:32 PDT
Committed r83271: <http://trac.webkit.org/changeset/83271>
Comment 5 WebKit Review Bot 2011-04-08 03:20:56 PDT
http://trac.webkit.org/changeset/83271 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
http/tests/inspector/resource-har-conversion.html
http/tests/inspector/resource-parameters.html