Bug 58025 – Web Inspector: Bugs in some corner cases in the text editor

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Andrey Adaikin]

1) The very last _empty_ line would not be deleted if you hit a Backspace on it, or the selection text to be deleted is extended to the very bottom of the editor.

2) An odd corner case: delete all source code from the editor, hit backspace on the only empty line, then add a character. In this case the browser will insert a TEXT node instead of a DIV node for a lineRow.

[Andrey Adaikin]

Created attachment 88605 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 88605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88605&action=review

> Source/WebCore/ChangeLog:7
> +

ChangeLog entry should briefly explain the change, please don't leave it empty.

> Source/WebCore/inspector/front-end/TextViewer.js:1145
> +        for (var lineRow = element; lineRow; lineRow = lineRow.parentElement) {

Why not use this loop exclusively without relying on the class name above?

[Yury Semikhatsky]

Comment on attachment 88605 [details]
Patch

Also, please update copyright years in the files you edit.

[Andrey Adaikin]

Comment on attachment 88605 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88605&action=review

>> Source/WebCore/ChangeLog:7
>> +
> 
> ChangeLog entry should briefly explain the change, please don't leave it empty.

done.

>> Source/WebCore/inspector/front-end/TextViewer.js:1145
>> +        for (var lineRow = element; lineRow; lineRow = lineRow.parentElement) {
> 
> Why not use this loop exclusively without relying on the class name above?

Because an element may not be attached to the this._container any more (e.g. after a DOMNodeRemoved event). The loop is to handle the odd case when the browser would insert a line-row without the "webkit-line-content" className right under the this._container.

[Andrey Adaikin]

Created attachment 88629 [details]
Patch

[Pavel Podivilov]

Comment on attachment 88629 [details]
Patch

Clearing flags on attachment: 88629

Committed r83285: <http://trac.webkit.org/changeset/83285>

[Pavel Podivilov]

All reviewed patches have been landed.  Closing bug.