Summary: | Web Inspector: Bugs in some corner cases in the text editor | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Adaikin <aandrey> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, podivilov, rik, timothy, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Andrey Adaikin
2011-04-07 03:26:00 PDT
Created attachment 88605 [details]
Patch
Comment on attachment 88605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88605&action=review > Source/WebCore/ChangeLog:7 > + ChangeLog entry should briefly explain the change, please don't leave it empty. > Source/WebCore/inspector/front-end/TextViewer.js:1145 > + for (var lineRow = element; lineRow; lineRow = lineRow.parentElement) { Why not use this loop exclusively without relying on the class name above? Comment on attachment 88605 [details]
Patch
Also, please update copyright years in the files you edit.
Comment on attachment 88605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88605&action=review >> Source/WebCore/ChangeLog:7 >> + > > ChangeLog entry should briefly explain the change, please don't leave it empty. done. >> Source/WebCore/inspector/front-end/TextViewer.js:1145 >> + for (var lineRow = element; lineRow; lineRow = lineRow.parentElement) { > > Why not use this loop exclusively without relying on the class name above? Because an element may not be attached to the this._container any more (e.g. after a DOMNodeRemoved event). The loop is to handle the odd case when the browser would insert a line-row without the "webkit-line-content" className right under the this._container. Created attachment 88629 [details]
Patch
Comment on attachment 88629 [details] Patch Clearing flags on attachment: 88629 Committed r83285: <http://trac.webkit.org/changeset/83285> All reviewed patches have been landed. Closing bug. |