Summary: | Document leaks when navigating away from a scrolled page | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Stephanie Lewis <slewis> | ||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, eric, slewis, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.6 | ||||||||
Attachments: |
|
Description
Stephanie Lewis
2011-04-06 16:18:10 PDT
Created attachment 88542 [details]
patch
Comment on attachment 88542 [details]
patch
I don’t understand this patch. It adds two new functions, but nobody calls the Document function.
the call to to cancelEnqueuedEvents is in Document::detach. It would be more concise I suppose to just call the QueueEvent function from there and not add a function to Document. Comment on attachment 88542 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=88542&action=review > Source/WebCore/dom/Document.cpp:3553 > +void Document::cancelEnqueuedEvents() > +{ > + m_eventQueue->cancelEnqueuedEvents(); > +} I suggest just doing this in Document::detach instead of adding a function for it. committed http://trac.webkit.org/changeset/83128 http://trac.webkit.org/changeset/83128 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: fast/dom/52776.html fast/text/complex-text-opacity.html fast/text/international/bidi-AN-after-L.html fast/text/international/bidi-AN-after-empty-run.html fast/text/international/bidi-CS-after-AN.html fast/text/international/bidi-mirror-he-ar.html fast/text/international/bidi-neutral-run.html platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html |