Bug 57985

Summary:

Fix some threading issues in IconDatabase.

Product:

WebKit

Reporter:

David Levin <levin>

Component:

Page Loading

Assignee:

David Levin <levin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

58092

Attachments:

Description	Flags
Patch	none
Patch	beidson: review+, commit-queue: commit-queue-

Description David Levin 2011-04-06 14:52:49 PDT

Fix some threading issues that I uncovered while working on bug 31639.

Comment 1 David Levin 2011-04-06 14:57:05 PDT

Created attachment 88520 [details]
Patch

Comment 2 David Levin 2011-04-07 14:44:51 PDT

Created attachment 88703 [details]
Patch

Comment 3 Brady Eidson 2011-04-14 13:57:40 PDT

Comment on attachment 88703 [details]
Patch

Okay!

Comment 4 WebKit Commit Bot 2011-04-14 15:10:04 PDT

Comment on attachment 88703 [details]
Patch

Rejecting attachment 88703 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'ap..." exit_code: 2

Last 500 characters of output:
Tools/Scripts/svn-apply', u'--reviewer', u'Brady Eidson', u'--force']" exit_code: 1

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/loader/icon/IconDatabase.cpp
Hunk #3 FAILED at 1571.
1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/loader/icon/IconDatabase.cpp.rej

Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Brady Eidson', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8398759

Comment 5 David Levin 2011-04-14 15:11:45 PDT

Will land by hand shortly.

Comment 6 David Levin 2011-04-14 16:52:40 PDT

Committed as http://trac.webkit.org/changeset/83913