Bug 57980 – [Qt] Reduce default test app window size for environments with small display sizes

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Keith Kyzivat]

Qt Gui applications on some embedded Qt environments will crash if the size of windows extends beyond the display size.

Currently the QtTestBrowser and MiniBrowser test browsers will set their main window size to 800x600 for all platforms except Symbian (which sets it to WindowMaximized).

These platforms should not to crash on startup.

[Benjamin Poulain]

Sounds like

[Benjamin Poulain]

Sounds like a bug in Qt, not WebKit.

[Keith Kyzivat]

Created attachment 88517 [details]
Patch

[Keith Kyzivat]

It does sound like a bug in Qt, however having a workaround in the meantime would be nice.

See my patch for one possible solution.

If you don't like that, I can add a -maximized or -size option to QtTestBrowser and MiniBrowser.

[Benjamin Poulain]

Comment on attachment 88517 [details]
Patch

Ok, unless there is an insanely good reason not to fix the bug where it is, I really don't like this patch. :)
Workaround for platform bug, for a platform we control, is something we can generally avoid.

[Keith Kyzivat]

Change title from:
 [Qt] Reduce default test app window size for embedded qt
to:
 [Qt] Reduce default test app window size for environments with small display sizes

[Keith Kyzivat]

It still would be nice for small-screen devices (mobile phones, PDAs, GPS units, ...) to start maximized without specifying any command line arguments.

I think I have come up with a reasonable way to do this without having platform #ifdefs.

Get the screen geometry of the default screen from QApplication::desktop()->screenGeometry().size(), and if it is less than some defined dimensions (640x480?), set the application window maximized.

Does this seem reasonable?

[Keith Kyzivat]

Created attachment 88563 [details]
Patch auto-maximizing if screen size of default screen is < 640 width or < 480 height.

Not a proper patch, as it depends on the patch I provided in bug 58007 (Attachment 88558 [details]), so not r?ing it.

[Benjamin Poulain]

I suggest to close this, fix the window manager and 58007 instead.

[Keith Kyzivat]

<lgombos> seems reasonable to detect screen size runtime and make a decision
<benjaminp> that is the job of the window manager, not our
<benjaminp> I have played with a few embedded system, and appart from Symbian, the WM usually does its job
<keithel> benjaminp, If a main window is sized > screen size, what normally happens on X?
<keithel> (suppose I should try this, its easy enough).
<lgombos> ok, but we have resize(800, 600) hardcoded so window manager can not pick default size
<benjaminp> keithel: depend on the window manager, usually it is resized to the current screen size
<benjaminp> lgombos: of course it can, the WM cannot change if you set the minimum size
<benjaminp> but again, I am not strongly against the change... I just think it is a fix at the wrong place
<lgombos> benjaminp: I see, so the WM does not need to honour 800x 600
<benjaminp> nope
<benjaminp> that is why that works on QtEmbedded or Maemo
<lgombos> benjaminp: thanks for the help, I understand your argument better.

[Keith Kyzivat]

Should be fixed in window manager.