Bug 57943

Summary: Move RenderBlock::positionNewFloatOnLine to RenderBlockLineLayout.cpp
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: abarth, eric, mitz, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 57851    
Attachments:
Description Flags
cleanup eric: review+

Description Ryosuke Niwa 2011-04-06 05:58:04 PDT 
positionNewFloatOnLine is only used in RenderBlockLineLayout.cpp.  We should move this function to RenderBlockLineLayout.cpp.
Comment 1 Ryosuke Niwa 2011-04-06 06:07:45 PDT 
Created attachment 88404 [details]
cleanup
Comment 2 Eric Seidel (no email) 2011-04-06 06:08:56 PDT 
Comment on attachment 88404 [details]
cleanup

Yay simple patches!
Comment 3 Ryosuke Niwa 2011-04-06 07:10:16 PDT 
Committed r83042: <http://trac.webkit.org/changeset/83042>
Comment 4 WebKit Review Bot 2011-04-06 07:34:03 PDT 
http://trac.webkit.org/changeset/83042 might have broken GTK Linux 64-bit Debug
Comment 5 mitz 2011-04-06 08:13:38 PDT 
RenderBlock.h used to list functions implemented in RenderBlockLineLayout.cpp in a separate section. Perhaps this is no longer the case.
Comment 6 Ryosuke Niwa 2011-04-06 08:17:19 PDT 
(In reply to comment #5)
> RenderBlock.h used to list functions implemented in RenderBlockLineLayout.cpp in a separate section. Perhaps this is no longer the case.

Oops, I missed that.  Fixing it now.
Comment 7 Ryosuke Niwa 2011-04-06 08:20:21 PDT 
Fixed RenderBlock.h in http://trac.webkit.org/changeset/83052.