Bug 57911

Summary: [Chromium] Fix relocation problem of popup window which introduces autofill popup sometimes moves to screen's top left corner.
Product: WebKit Reporter: Naoki Takano <honten>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dhollowa, isherman, thakis, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Description Naoki Takano 2011-04-05 18:10:18 PDT 
[Chromium] Fix relocation problem of popup window which introduces autofill popup sometimes moves to screen's top left corner.
Comment 1 Naoki Takano 2011-04-05 18:18:29 PDT 
Created attachment 88347 [details]
Patch
Comment 2 Naoki Takano 2011-04-05 18:21:04 PDT 
Comment on attachment 88347 [details]
Patch

Please review.
Comment 3 Nico Weber 2011-04-05 18:59:20 PDT 
None of use are reviewers. I'm cc'ing tkent, who reviewed https://bugs.webkit.org/show_bug.cgi?id=51382

In general, manual tests are bad. Is there any way to turn this into an automated test?
Comment 4 Naoki Takano 2011-04-05 19:01:06 PDT 
I agree.

But I already ask Ilya but he says he doesn't know.

I believe there is no automation test for popup window layout, right?
Comment 5 Ilya Sherman 2011-04-06 00:36:03 PDT 
Comment on attachment 88347 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88347&action=review

> Source/WebCore/ChangeLog:5
> +        [Chromium] Fix relocation problem of popup window which introduces autofill popup sometimes moves to screen&apos;s top left corner.

nit: &apos; -> '

> Source/WebCore/ChangeLog:6
> +        https://bugs.webkit.org/show_bug.cgi?id=57911

nit: Please add a link to the Chromium bug.
Comment 6 Naoki Takano 2011-04-06 11:52:18 PDT 
Created attachment 88475 [details]
Patch
Comment 7 Naoki Takano 2011-04-06 11:52:39 PDT 
Comment on attachment 88475 [details]
Patch

Please review again.
Comment 8 Naoki Takano 2011-04-06 23:51:07 PDT 
Is there anybody who can review my patch?

(In reply to comment #7)
> (From update of attachment 88475 [details])
> Please review again.
Comment 9 WebKit Commit Bot 2011-04-07 18:19:15 PDT 
Comment on attachment 88475 [details]
Patch

Clearing flags on attachment: 88475

Committed r83237: <http://trac.webkit.org/changeset/83237>
Comment 10 WebKit Commit Bot 2011-04-07 18:19:20 PDT 
All reviewed patches have been landed.  Closing bug.