Bug 57911

Summary: [Chromium] Fix relocation problem of popup window which introduces autofill popup sometimes moves to screen's top left corner.
Product: WebKit Reporter: Naoki Takano <honten>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dhollowa, isherman, thakis, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Naoki Takano
Reported 2011-04-05 18:10:18 PDT
[Chromium] Fix relocation problem of popup window which introduces autofill popup sometimes moves to screen's top left corner.
Attachments
Patch (3.13 KB, patch)
2011-04-05 18:18 PDT, Naoki Takano 		no flags
DetailsFormatted DiffDiff
Patch (3.19 KB, patch)
2011-04-06 11:52 PDT, Naoki Takano 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Naoki Takano
Comment 1 2011-04-05 18:18:29 PDT
Created attachment 88347 [details] Patch
Naoki Takano
Comment 2 2011-04-05 18:21:04 PDT
Comment on attachment 88347 [details] Patch Please review.
Nico Weber
Comment 3 2011-04-05 18:59:20 PDT
None of use are reviewers. I'm cc'ing tkent, who reviewed https://bugs.webkit.org/show_bug.cgi?id=51382 In general, manual tests are bad. Is there any way to turn this into an automated test?
Naoki Takano
Comment 4 2011-04-05 19:01:06 PDT
I agree. But I already ask Ilya but he says he doesn't know. I believe there is no automation test for popup window layout, right?
Ilya Sherman
Comment 5 2011-04-06 00:36:03 PDT
Comment on attachment 88347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88347&action=review > Source/WebCore/ChangeLog:5 > + [Chromium] Fix relocation problem of popup window which introduces autofill popup sometimes moves to screen&apos;s top left corner. nit: &apos; -> ' > Source/WebCore/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=57911 nit: Please add a link to the Chromium bug.
Naoki Takano
Comment 6 2011-04-06 11:52:18 PDT
Created attachment 88475 [details] Patch
Naoki Takano
Comment 7 2011-04-06 11:52:39 PDT
Comment on attachment 88475 [details] Patch Please review again.
Naoki Takano
Comment 8 2011-04-06 23:51:07 PDT
Is there anybody who can review my patch? (In reply to comment #7) > (From update of attachment 88475 [details]) > Please review again.
WebKit Commit Bot
Comment 9 2011-04-07 18:19:15 PDT
Comment on attachment 88475 [details] Patch Clearing flags on attachment: 88475 Committed r83237: <http://trac.webkit.org/changeset/83237>
WebKit Commit Bot
Comment 10 2011-04-07 18:19:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.