Bug 57878

Summary:

[Cairo] Hide the details of image masking in PlatformContextCairo

Product:

WebKit

Reporter:

Martin Robinson <mrobinson>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, rniwa, webkit.review.bot

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	none

Martin Robinson

Reported 2011-04-05 13:20:03 PDT

Now that we have have PlatformContextCairo, we can better encapsulate the logic in PlatformContextCairo. This removes the need to expose private Cairo details via the platform-independent GraphicsContext.

Attachments
Patch (11.52 KB, patch) 2011-04-05 13:40 PDT, Martin Robinson	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Martin Robinson

Comment 1 2011-04-05 13:40:15 PDT

Created attachment 88304 [details] Patch

Xan Lopez

Comment 2 2011-04-05 17:08:36 PDT

Comment on attachment 88304 [details] Patch r=me

Martin Robinson

Comment 3 2011-04-06 07:16:11 PDT

Comment on attachment 88304 [details] Patch Clearing flags on attachment: 88304 Committed r83044: <http://trac.webkit.org/changeset/83044>

Martin Robinson

Comment 4 2011-04-06 07:16:18 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 5 2011-04-06 07:34:21 PDT

http://trac.webkit.org/changeset/83044 might have broken GTK Linux 64-bit Debug

Ryosuke Niwa

Comment 6 2011-04-06 07:36:36 PDT

I think this patch broke WinCairo: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug/builds/21161/steps/compile-webkit/logs/stdio

Note You need to log in before you can comment on or make changes to this bug.