Bug 57861

Summary:

webkit-patch should print git's stderr when git svn dcommit fail

Product:

WebKit

Reporter:

Hajime Morrita <morrita>

Component:

Tools / Tests

Assignee:

Hajime Morrita <morrita>

Status:

REOPENED

Severity:

Normal

CC:

abarth, eric, jberlin, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Other

Bug Depends on:

57913

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none

Hajime Morrita

Reported 2011-04-05 10:30:57 PDT

webkit-patch gives no hint when dcommit fail, which makes diagnosis hard.

Attachments
Patch (1.19 KB, patch) 2011-04-05 10:53 PDT, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (2.36 KB, patch) 2011-04-05 13:01 PDT, Hajime Morrita	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Hajime Morrita

Comment 1 2011-04-05 10:53:50 PDT

Created attachment 88278 [details] Patch

Tony Chang

Comment 2 2011-04-05 11:36:42 PDT

Comment on attachment 88278 [details] Patch Rather than using isinstance, can we add a ScriptError __str__ method that prints the output?

Hajime Morrita

Comment 3 2011-04-05 13:01:08 PDT

Created attachment 88298 [details] Patch

Hajime Morrita

Comment 4 2011-04-05 13:02:56 PDT

Hi Tony, thank you for your prompt review! > (From update of attachment 88278 [details]) > Rather than using isinstance, can we add a ScriptError __str__ method that prints the output? Sure. I updated to do this.

Hajime Morrita

Comment 5 2011-04-05 14:04:26 PDT

Committed r82978: <http://trac.webkit.org/changeset/82978>

Jessie Berlin

Comment 6 2011-04-05 15:17:51 PDT

(In reply to comment #5) > Committed r82978: <http://trac.webkit.org/changeset/82978> Looks like this broke SL and Windows webkit-py test: http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/27740/steps/webkitpy-test/logs/stdio http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/11247/steps/webkitpy-test/logs/stdio

Adam Barth

Comment 7 2011-04-05 22:06:28 PDT

I tried fixing this on the bots, but didn't succeed. We need a python2.5 test environment.

Eric Seidel (no email)

Comment 8 2011-06-18 13:51:35 PDT

Attachment 88298 [details] was posted by a committer and has review+, assigning to Hajime Morita for commit.

Hajime Morrita

Comment 9 2011-06-19 18:21:48 PDT

This patch was landed, but rolled out due to mysterious regression. I have no idea for dealing with it.

Eric Seidel (no email)

Comment 10 2011-12-21 14:34:15 PST

Attachment 88298 [details] was posted by a committer and has review+, assigning to Hajime Morita for commit.

Hajime Morrita

Comment 11 2011-12-21 20:09:36 PST

Comment on attachment 88298 [details] Patch Obsoleting the patch since it has some compatibility problem.

Eric Seidel (no email)

Comment 12 2012-02-10 10:20:07 PST

Comment on attachment 88298 [details] Patch Cleared Adam Barth's review+ from obsolete attachment 88298 [details] so that this bug does not appear in http://webkit.org/pending-commit.

Note You need to log in before you can comment on or make changes to this bug.