Summary: | Crash logs not generated in 64-bit Windows 7 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pere Martir <pere.martir4> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Enhancement | CC: | ap, aroben, commit-queue, sfalken | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows 7 | ||||||||
Attachments: |
|
Description
Pere Martir
2011-04-05 07:40:58 PDT
This sounds very interesting! > http://trac.webkit.org/wiki/BuildingOnWindows#GettingCrashLogs That data should probably be in <http://www.webkit.org/quality/crashlogs.html>. Since WebKit site is in svn, one can just make a patch for it. Comment on attachment 88229 [details] Proposed patch The code change here looks fine. Thanks for fixing the bug! However, your patch needs a ChangeLog. <http://www.webkit.org/coding/contributing.html> explains how to write one. (In reply to comment #1) > This sounds very interesting! > > > http://trac.webkit.org/wiki/BuildingOnWindows#GettingCrashLogs > > That data should probably be in <http://www.webkit.org/quality/crashlogs.html>. Since WebKit site is in svn, one can just make a patch for it. The wiki page is specifically about getting run-webkit-tests to save crash logs automatically. The webkit.org page isn't specifically about run-webkit-tests. But maybe the info could be added there anyway. What I meant was that the webkit.org page didn't have any information about getting crash logs under Windows 7 at all. Oh, I see. The webkit.org page should be changed to say "Windows Vista or Windows 7", since the same technique works on both. Created attachment 88412 [details] Proposed patch with ChangeLog Some other points should also be modified in the trac Wiki. * I wondered if the test script also works in 64-bit since the wiki says very explicitly - installing "32-bit" Debugging Tools. * The wiki page doesn't mention that the Registry value "ForceQueue" must be set to 1 so that the crash logs are stored automatically, otherwise some GUI dialogs will pop up and pause the test script. This is actually mentioned in http://www.webkit.org/quality/crashlogs.html (In reply to comment #6) > Some other points should also be modified in the trac Wiki. Since it's a wiki, feel free to make the modifications yourself. > * I wondered if the test script also works in 64-bit since the wiki says very explicitly - installing "32-bit" Debugging Tools. I think we were just mistaken before that the 64-bit tools wouldn't work. (The 32-bit tools are still a good idea to have installed, though, since AFAIK you need the 32-bit tools for gflags to work, e.g.) > * The wiki page doesn't mention that the Registry value "ForceQueue" must be set > to 1 so that the crash logs are stored automatically, otherwise some > GUI dialogs will pop up and pause the test script. This is actually mentioned in http://www.webkit.org/quality/crashlogs.html The wiki page is all about getting run-webkit-tests's automatic crash log saving to work. Is ForceQueue really needed for that? run-webkit-tests installs a post-mortem debugger, which should prevent the WER dialog from appearing at all. Pere, if you want your patch to be committed you should mark it cq?. Comment on attachment 88412 [details] Proposed patch with ChangeLog Rejecting attachment 88412 [details] from commit-queue. pere.martir4@gmail.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 88412 [details]
Proposed patch with ChangeLog
Non-committers should mark patches cq?. Then a committer can mark it cq+.
Comment on attachment 88412 [details] Proposed patch with ChangeLog Clearing flags on attachment: 88412 Committed r83310: <http://trac.webkit.org/changeset/83310> All reviewed patches have been landed. Closing bug. |