Bug 57839 – [Qt] [Symbian] the include file for symbian should be case sensitive

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Liang Qi]

In Source/JavaScriptCore/wtf/PageAllocatorSymbian.h,

it includes 
#include <wtf/BitMap.h>

But the real file name is Bitmap.h.

Then it should be
#include <wtf/Bitmap.h>

Otherwise, it will break the makefile build system for armcc & gcce.

[Liang Qi]

Created attachment 88217 [details]
A patch to fix the include file name for wtf/PageAllocatorSymbian.h

[Jocelyn Turcotte]

Some stuff to fix in you Changelog entry:

- Specify this bug's URL instead of the bug number for quick access.
- Leave a blank line between the URL and the patch long description.
- In "Correct a include file name.", "a" should be written "an".

See there if you want more information:
http://trac.webkit.org/wiki/QtWebKitContrib

Have a look at previous entries in Changelogs, this should give you a reliable template.

[Jocelyn Turcotte]

Don't forget to press Details on your attachment and set the review flag to "?" if you want your patch to appear in the review queue ( webkit.org/pending-review ).

Set the commit-queue flag to "?" as well if you want your patch to be committed automatically once it got approved.

[Siddharth Mathur]

Please also fix the rationale to simply say that "Use correct case of file name so as to work on Unix/Linux build hosts" or similar. This has nothing to do with Makefile/ARMCC/GCCE

[Liang Qi]

Created attachment 88220 [details]
A patch to fix the include file name for wtf/PageAllocatorSymbian.h

Update the changelog.

[Siddharth Mathur]

(In reply to comment #5)
> Created an attachment (id=88220) [details]
> A patch to fix the include file name for wtf/PageAllocatorSymbian.h
> 
> Update the changelog.

Looks good. Many thanks. 
( I am not a reviewer, so someone else will have to bless it with r+)

[Liang Qi]

Created attachment 88221 [details]
A patch to fix the include file name for wtf/PageAllocatorSymbian.h

[Benjamin Poulain]

Comment on attachment 88221 [details]
A patch to fix the include file name for wtf/PageAllocatorSymbian.h

Good catch.

[WebKit Commit Bot]

Comment on attachment 88221 [details]
A patch to fix the include file name for wtf/PageAllocatorSymbian.h

Rejecting attachment 88221 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2

Last 500 characters of output:
iled to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Benjamin Poulain', u'-..." exit_code: 2

Parsed 2 diffs from patch file(s).
patching file Source/JavaScriptCore/ChangeLog
patch: **** malformed patch at line 17:  2011-04-05  Nikolas Zimmermann  <[e-mail]>

patching file Source/JavaScriptCore/wtf/PageAllocatorSymbian.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Benjamin Poulain', u'-..." exit_code: 2

Full output: http://queues.webkit.org/results/8341193

[Liang Qi]

Created attachment 88423 [details]
A patch to fix the include file name for wtf/PageAllocatorSymbian.h

[Benjamin Poulain]

Comment on attachment 88423 [details]
A patch to fix the include file name for wtf/PageAllocatorSymbian.h

Let's try again.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 88423 [details]:

java/lc3/JSObject/ToObject-001.html bug 53091 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 88423 [details]
A patch to fix the include file name for wtf/PageAllocatorSymbian.h

Clearing flags on attachment: 88423

Committed r83059: <http://trac.webkit.org/changeset/83059>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.