Bug 57781 – [WinCairo] Get WebKit2 Up and Running

• Component: WebKit2
• Status: RESOLVED INVALID

[Brent Fulgham]

This bug tracks some changes needed to get a functioning WebKit2 layer working.

[Brent Fulgham]

Created attachment 88166 [details]
Patch

[Martin Robinson]

Comment on attachment 88166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88166&action=review

Great stuff. Do you mind splitting out the Cairo specific bits from the Windows specific bits? I can review that section more easily and I believe it's a distinct change.

> Source/WebKit2/Shared/API/c/cairo/WKGraphicsContextCairo.cpp:3
> +/*
> + * Copyright (C) 2011 Igalia SL All rights reserved.
> + *

Is there something funky with your diff? This file is listed twice.

> Source/WebKit2/Shared/API/c/cairo/WKGraphicsContextCairo.h:3
> +/*
> + * Copyright (C) 2011 Igalia SL All rights reserved.
> + *

Here as well.

> Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp:45
> +    cairo_surface_t* image = cairo_image_surface_create_for_data((unsigned char*)data(),
> +                                               CAIRO_FORMAT_ARGB32,
> +                                               m_size.width(), m_size.height(),
> +                                               m_size.width() * 4);
> +

Please fix the spacing here.

> Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp:48
> +    cairo_t* bitmapContext = cairo_create(image);
> +    cairo_surface_write_to_png(image, "E:\\Projects\\dump_create.png");
> +    cairo_surface_destroy(image);

I assume this is temporary. I hope so, because I don't have an E drive. :)

> Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp:53
> +    cairo_translate(bitmapContext, 0, m_size.height());
> +    cairo_scale(bitmapContext, 1, -1);
> +

Is this still necessary for non-CG ports?

> Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp:66
> +    cairo_pattern_t* pattern = cairo_pattern_create_for_surface(image);

Mind using a RefPtr here?

> Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp:120
> +    cairo_surface_t* copy = copySurface(makeImage());

This is only used in one place, so you might as well move it inline. copySurface doesn't provide much extra description over makeImageCopy.

> Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp:133
> +                                               CAIRO_FORMAT_ARGB32,
> +                                               m_size.width(), m_size.height(),
> +                                               m_size.width() * 4);
> +

Please fix the spacing here.

[Brent Fulgham]

Some of this code will be landed under 58242.  Will revise this patch to reflect that after the other bug lands.

[Adam Roben (:aroben)]

Comment on attachment 88166 [details]
Patch

Clearing the r? flag since we're waiting on another bug.

[Brent Fulgham]

This isn't going to happen in the near future. Closing this ancient bug, and we can open a new one when this development is actually ongoing.