Bug 57732

Summary:

[CSS 3] setting the 'cursor' property to 'no-drop' causes a crash

Product:

WebKit

Reporter:

Ryan <aikavanak>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, aroben, jeffm

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Minimal test based on manual-tests/cursor.html	none
Proposed patch	eric: review-
Backtrace	none

Ryan

Reported 2011-04-03 14:26:19 PDT

Created attachment 88021 [details] Minimal test based on manual-tests/cursor.html When the cursor is set to 'no-drop', WebKit will crash. Appears to be because no platform cursor is set in the Cursor::NoDrop case in Cursor::ensurePlatformCursor() in CursorWin.cpp.

Attachments
Minimal test based on manual-tests/cursor.html (161 bytes, text/html) 2011-04-03 14:26 PDT, Ryan	no flags	Details
Proposed patch (1.30 KB, patch) 2011-04-03 22:33 PDT, Ryan	eric: review-	Details Formatted Diff Diff
Backtrace (2.10 KB, text/plain) 2011-04-07 00:40 PDT, Ryan	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Ryan

Comment 1 2011-04-03 22:33:59 PDT

Created attachment 88033 [details] Proposed patch On Windows, set a cursor for the 'no-drop' property, instead of leaving it unset and crashing. The cursor is the same one used for 'not-allowed' (IDC_NO).

Adam Roben (:aroben)

Comment 2 2011-04-04 11:29:33 PDT

Comment on attachment 88033 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=88033&action=review > Source/WebCore/ChangeLog:11 > + No new tests. WebCore/manual-tests/cursor.html already contains a > + test for 'no-drop'. Is it possible to make an automated test that would crash without this fix?

Adam Roben (:aroben)

Comment 3 2011-04-04 11:29:50 PDT

It would be nice to have a backtrace for the crash for future reference.

Ryan

Comment 4 2011-04-07 00:40:33 PDT

Created attachment 88587 [details] Backtrace Backtrace from Visual Studio 2005 Express debugger. Occurred when I moved the mouse cursor over the "nodrop" div in manual-tests/cursor.html.

Adam Roben (:aroben)

Comment 5 2011-04-07 05:57:27 PDT

Thanks, Ryan!

Eric Seidel (no email)

Comment 6 2011-04-26 16:11:06 PDT

Comment on attachment 88033 [details] Proposed patch How do we tes this? This seems obviously right otherwise.

Ryan

Comment 7 2011-05-25 17:56:40 PDT

(In reply to comment #6) > (From update of attachment 88033 [details]) > How do we tes this? This seems obviously right otherwise. I'm still new to WebKit development, so I'm not sure what the best way to test this would be, given that browsers don't currently have a way to control the mouse cursor. Would it be viable to do a somewhat artificial test, perhaps by launching Safari maximized, load a page with the no-drop style applied to the entire body, and call SetCursorPos to move the cursor onto the page?

Ryan

Comment 8 2011-10-01 15:36:06 PDT

Looks like this was fixed by jeffm@apple.com in revision 95057.

Jeff Miller

Comment 9 2011-10-03 09:40:14 PDT

(In reply to comment #8) > Looks like this was fixed by jeffm@apple.com in revision 95057. Yes, I remember fixing this exact crash in <http://trac.webkit.org/changeset/95057>.

Note You need to log in before you can comment on or make changes to this bug.