Summary: | didFailToSendSyncMessage should not be a client call | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | WebKit2 | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED DUPLICATE | ||||||
Severity: | Normal | CC: | andersca, sam | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Alexey Proskuryakov
2011-04-02 22:12:04 PDT
Created attachment 87995 [details]
proposed patch
Comment on attachment 87995 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=87995&action=review > Source/WebKit2/Platform/CoreIPC/Connection.cpp:422 > + exit(0); Funny that this error condition exits 0. I guess that's to mean that the process intended to end itself? Comment on attachment 87995 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=87995&action=review >> Source/WebKit2/Platform/CoreIPC/Connection.cpp:422 > > Funny that this error condition exits 0. I guess that's to mean that the process intended to end itself? This is a fatal condition (most likely, the server process has exited already) - but if we return a super rare null result, we can crash instead if cleanly exiting a moment later. We don't want all client connections to do this, so I think this should be a callback function on the connection instead. |