| Summary: | Remove an unnecessary extra computeLogicalWidth() from line layout | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||
| Component: | Layout and Rendering | Assignee: | mitz | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, eric, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
mitz
2011-04-02 13:52:40 PDT
Created attachment 87986 [details]
Remove call to computeLogicalWidth(), progress on MathML tests
Comment on attachment 87986 [details]
Remove call to computeLogicalWidth(), progress on MathML tests
r=me
Fixed in r82775 <http://trac.webkit.org/changeset/82775> The change caused multiple <details> tests to fail. While they have probably progressed as well, I am going to revert the change until I figure out why <details> is broken. http://trac.webkit.org/changeset/82775 might have broken Qt Linux Release The following tests are not passing: fast/html/details-add-summary-1-and-click.html fast/html/details-add-summary-1.html fast/html/details-add-summary-10-and-click.html fast/html/details-add-summary-10.html fast/html/details-add-summary-2-and-click.html fast/html/details-add-summary-2.html fast/html/details-add-summary-3-and-click.html fast/html/details-add-summary-3.html fast/html/details-add-summary-4-and-click.html fast/html/details-add-summary-4.html fast/html/details-add-summary-5-and-click.html fast/html/details-add-summary-5.html fast/html/details-add-summary-6-and-click.html fast/html/details-add-summary-6.html fast/html/details-add-summary-7-and-click.html fast/html/details-add-summary-7.html fast/html/details-add-summary-8-and-click.html fast/html/details-add-summary-8.html fast/html/details-add-summary-9-and-click.html fast/html/details-add-summary-9.html fast/html/details-no-summary1.html fast/html/details-no-summary2.html fast/html/details-no-summary3.html fast/html/details-no-summary4.html fast/html/details-open-javascript.html fast/html/details-open1.html fast/html/details-open2.html fast/html/details-open3.html fast/html/details-open4.html fast/html/details-open5.html fast/html/details-open6.html fast/html/details-position.html fast/html/details-remove-summary-1-and-click.html fast/html/details-remove-summary-1.html fast/html/details-remove-summary-2-and-click.html fast/html/details-remove-summary-2.html fast/html/details-remove-summary-3-and-click.html fast/html/details-remove-summary-3.html fast/html/details-remove-summary-4-and-click.html fast/html/details-remove-summary-4.html fast/html/details-remove-summary-5-and-click.html fast/html/details-remove-summary-5.html fast/html/details-remove-summary-6-and-click.html fast/html/details-remove-summary-6.html fast/html/details-writing-mode.html Reverted in r82777 <http://trac.webkit.org/projects/82777>. Fixed in r82786 <http://trac.webkit.org/changeset/82786> There are some failures in media tests on GTK and Qt following this change. I am looking into them. http://trac.webkit.org/changeset/82786 might have broken GTK Linux 32-bit Release The following tests are not passing: fast/layers/video-layer.html fast/table/colspanMinWidth-vertical.html media/audio-controls-rendering.html media/audio-repaint.html media/controls-strict.html media/controls-styling.html media/controls-without-preload.html media/media-document-audio-repaint.html media/video-controls-rendering.html media/video-empty-source.html media/video-no-audio.html media/video-volume-slider.html media/video-zoom-controls.html Filed bug 57719. |