Bug 57711

Summary: Remove an unnecessary extra computeLogicalWidth() from line layout
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Remove call to computeLogicalWidth(), progress on MathML tests hyatt: review+

Description mitz 2011-04-02 13:52:40 PDT
Remove an unnecessary extra computeLogicalWidth() from line layout
Comment 1 mitz 2011-04-02 14:06:15 PDT
Created attachment 87986 [details]
Remove call to computeLogicalWidth(), progress on MathML tests
Comment 2 Dave Hyatt 2011-04-02 14:31:42 PDT
Comment on attachment 87986 [details]
Remove call to computeLogicalWidth(), progress on MathML tests

r=me
Comment 3 mitz 2011-04-02 14:38:46 PDT
Fixed in r82775 <http://trac.webkit.org/changeset/82775>
Comment 4 mitz 2011-04-02 15:17:31 PDT
The change caused multiple <details> tests to fail. While they have probably progressed as well, I am going to revert the change until I figure out why <details> is broken.
Comment 5 WebKit Review Bot 2011-04-02 15:19:11 PDT
http://trac.webkit.org/changeset/82775 might have broken Qt Linux Release
The following tests are not passing:
fast/html/details-add-summary-1-and-click.html
fast/html/details-add-summary-1.html
fast/html/details-add-summary-10-and-click.html
fast/html/details-add-summary-10.html
fast/html/details-add-summary-2-and-click.html
fast/html/details-add-summary-2.html
fast/html/details-add-summary-3-and-click.html
fast/html/details-add-summary-3.html
fast/html/details-add-summary-4-and-click.html
fast/html/details-add-summary-4.html
fast/html/details-add-summary-5-and-click.html
fast/html/details-add-summary-5.html
fast/html/details-add-summary-6-and-click.html
fast/html/details-add-summary-6.html
fast/html/details-add-summary-7-and-click.html
fast/html/details-add-summary-7.html
fast/html/details-add-summary-8-and-click.html
fast/html/details-add-summary-8.html
fast/html/details-add-summary-9-and-click.html
fast/html/details-add-summary-9.html
fast/html/details-no-summary1.html
fast/html/details-no-summary2.html
fast/html/details-no-summary3.html
fast/html/details-no-summary4.html
fast/html/details-open-javascript.html
fast/html/details-open1.html
fast/html/details-open2.html
fast/html/details-open3.html
fast/html/details-open4.html
fast/html/details-open5.html
fast/html/details-open6.html
fast/html/details-position.html
fast/html/details-remove-summary-1-and-click.html
fast/html/details-remove-summary-1.html
fast/html/details-remove-summary-2-and-click.html
fast/html/details-remove-summary-2.html
fast/html/details-remove-summary-3-and-click.html
fast/html/details-remove-summary-3.html
fast/html/details-remove-summary-4-and-click.html
fast/html/details-remove-summary-4.html
fast/html/details-remove-summary-5-and-click.html
fast/html/details-remove-summary-5.html
fast/html/details-remove-summary-6-and-click.html
fast/html/details-remove-summary-6.html
fast/html/details-writing-mode.html
Comment 6 mitz 2011-04-02 15:22:03 PDT
Reverted in r82777 <http://trac.webkit.org/projects/82777>.
Comment 7 mitz 2011-04-02 18:48:43 PDT
Fixed in r82786 <http://trac.webkit.org/changeset/82786>
Comment 8 mitz 2011-04-02 20:23:56 PDT
There are some failures in media tests on GTK and Qt following this change. I am looking into them.
Comment 9 WebKit Review Bot 2011-04-02 22:17:49 PDT
http://trac.webkit.org/changeset/82786 might have broken GTK Linux 32-bit Release
The following tests are not passing:
fast/layers/video-layer.html
fast/table/colspanMinWidth-vertical.html
media/audio-controls-rendering.html
media/audio-repaint.html
media/controls-strict.html
media/controls-styling.html
media/controls-without-preload.html
media/media-document-audio-repaint.html
media/video-controls-rendering.html
media/video-empty-source.html
media/video-no-audio.html
media/video-volume-slider.html
media/video-zoom-controls.html
Comment 10 mitz 2011-04-02 22:33:15 PDT
Filed bug 57719.