Bug 57699

Summary:

V8StringCallback.cpp requires V8Binding.h

Product:

WebKit

Reporter:

Ryuan Choi <ryuan.choi>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dglazkov, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Description Ryuan Choi 2011-04-01 22:34:29 PDT

V8StringCallback use v8String() which is in V8Binding.h
But, it doesn't include V8Binding.h.

I checked chromium port, but it was fine because of magic file including many cpp files.

I believe that it should be fixed because v8 can be used for other ports.
Currently qt have v8 option, but it looks not compiled because of some reasons with this.

Comment 1 Ryuan Choi 2011-04-01 22:38:55 PDT

Created attachment 87969 [details]
Patch

Comment 2 Eric Seidel (no email) 2011-04-03 22:55:52 PDT

What's the magic file?

Comment 3 Ryuan Choi 2011-04-03 23:21:25 PDT

(In reply to comment #2)
> What's the magic file?

Thank you for your review.
Magic files which I said are V8DerivedSources1.cpp ~ V8DerivedSources8.cpp
including a list of cpp files.

Comment 4 WebKit Commit Bot 2011-04-04 00:16:32 PDT

Comment on attachment 87969 [details]
Patch

Clearing flags on attachment: 87969

Committed r82802: <http://trac.webkit.org/changeset/82802>

Comment 5 WebKit Commit Bot 2011-04-04 00:16:37 PDT

All reviewed patches have been landed.  Closing bug.