Bug 57697

Summary:

mfenced skips the first separator if the separators attribute contains multiple separators

Product:

WebKit

Reporter:

mitz

Component:

MathML

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, dbarton, mitz, webkit.review.bot, xun.sun

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

URL:

data:text/html,%3Cmath%20xmlns=%22http://www.w3.org/1998/Math/MathML%22%3E%3Cmfenced%20separators=%22123%22%3E%3Cmi%3Ex%3C/mi%3E%3Cmi%3Ey%3C/mi%3E%3Cmi%3Ez%3C/mi%3E/mfenced%3E%3C/math%3E

Attachments:

Description	Flags
A proposed patch	none
Patch	mitz: review-
Patch	none

mitz

Reported 2011-04-01 22:26:15 PDT

When the separators attribute of the mfenced element contains more than one separator, the first separator is skipped over. The URL contains a test case that shows this.

Attachments
A proposed patch (1.40 KB, patch) 2011-10-16 21:04 PDT, Xun Sun	no flags	Details Formatted Diff Diff
Patch (1.46 KB, patch) 2011-10-16 21:14 PDT, Xun Sun	mitz: review-	Details Formatted Diff Diff
Patch (31.34 KB, patch) 2011-12-19 21:57 PST, Dave Barton	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2011-04-01 22:39:17 PDT

<rdar://problem/9225769>

Xun Sun

Comment 2 2011-10-16 21:04:45 PDT

Created attachment 111204 [details] A proposed patch

WebKit Review Bot

Comment 3 2011-10-16 21:09:13 PDT

Attachment 111204 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Xun Sun

Comment 4 2011-10-16 21:14:54 PDT

Created attachment 111205 [details] Patch

Xun Sun

Comment 5 2011-10-22 21:08:10 PDT

(In reply to comment #4) > Created an attachment (id=111205) [details] > Patch Can someone please review this patch and see if it is suitable for integration?

mitz

Comment 6 2011-10-22 21:52:40 PDT

Comment on attachment 111205 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111205&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) A test case is required when fixing this sort of bug.

Dave Barton

Comment 7 2011-12-19 21:57:23 PST

Created attachment 119987 [details] Patch

Xun Sun

Comment 8 2011-12-28 07:55:43 PST

(In reply to comment #6) > (From update of attachment 111205 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=111205&action=review > > Source/WebCore/ChangeLog:8 > > + No new tests. (OOPS!) > A test case is required when fixing this sort of bug. Dave Barton provided test cases to accompany this fix in comment #7. Can you please review again? And happy new year!

WebKit Review Bot

Comment 9 2011-12-29 14:49:18 PST

Comment on attachment 119987 [details] Patch Clearing flags on attachment: 119987 Committed r103824: <http://trac.webkit.org/changeset/103824>

WebKit Review Bot

Comment 10 2011-12-29 14:49:23 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.