Bug 57621

Summary: [Qt] Install targets are not working correctly for modularized Qt and QtWebkit
Product: WebKit Reporter: Kristian Amlie <kristian.amlie>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major CC: abarth, ademar, benjamin, cmarcelo, commit-queue, eric, menard, ossy, webkit.review.bot
Priority: P3 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Install-correct-header-files-for-webkit
none
Same-patch-with-whitespace-changes-removed none

Kristian Amlie
Reported 2011-04-01 06:01:25 PDT
See attached patch for details regarding the fix.
Attachments
Install-correct-header-files-for-webkit (7.01 KB, patch)
2011-04-01 06:03 PDT, Kristian Amlie 		no flags
DetailsFormatted DiffDiff
Same-patch-with-whitespace-changes-removed (2.78 KB, patch)
2011-04-01 06:04 PDT, Kristian Amlie 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kristian Amlie
Comment 1 2011-04-01 06:03:12 PDT
Created attachment 87849 [details] Install-correct-header-files-for-webkit
Kristian Amlie
Comment 2 2011-04-01 06:04:47 PDT
Created attachment 87850 [details] Same-patch-with-whitespace-changes-removed For easier reading, here is the same patch with all whitespace-only changes removed.
Benjamin Poulain
Comment 3 2011-04-05 05:43:30 PDT
Anyone has any idea if this is correct? My knowledge of qmake magic is limited :(
Kristian Amlie
Comment 4 2011-04-08 06:04:36 PDT
FYI, I will be away for the next two weeks, so I will not respond during that time.
Eric Seidel (no email)
Comment 5 2011-04-10 15:50:13 PDT
This seems like an easy review for a qt reviewer. I think you meant to obsolete the first patch and mark the second one for review/cq.
Alexis Menard (darktears)
Comment 6 2011-04-11 06:53:21 PDT
Down-prioritize to P3 because the modularization project is a bit unknown state to us. We can revisit those patches after QtWebKit will find its way to Qt source tree.
Simon Hausmann
Comment 7 2011-04-29 05:03:02 PDT
Comment on attachment 87849 [details] Install-correct-header-files-for-webkit r=me . Holding off the cq+ per Alexis' comment.
Caio Marcelo de Oliveira Filho
Comment 8 2011-05-05 08:28:42 PDT
Why not removing the other references to QTDIR_build then?
WebKit Commit Bot
Comment 9 2011-05-05 13:14:04 PDT
Comment on attachment 87849 [details] Install-correct-header-files-for-webkit Clearing flags on attachment: 87849 Committed r85870: <http://trac.webkit.org/changeset/85870>
WebKit Commit Bot
Comment 10 2011-05-05 13:14:09 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 11 2011-05-05 16:06:43 PDT
http://trac.webkit.org/changeset/85870 might have broken GTK Linux 32-bit Debug The following tests are not passing: svg/W3C-SVG-1.1/animate-elem-46-t.svg
Ademar Reis
Comment 12 2011-05-10 13:31:22 PDT
Revision r85870 cherry-picked into qtwebkit-2.2 with commit b8f0053 <http://gitorious.org/webkit/qtwebkit/commit/b8f0053>
Note You need to log in before you can comment on or make changes to this bug.