Summary: | [Qt] Install targets are not working correctly for modularized Qt and QtWebkit | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kristian Amlie <kristian.amlie> | ||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Major | CC: | abarth, ademar, benjamin, cmarcelo, commit-queue, eric, menard, ossy, webkit.review.bot | ||||||
Priority: | P3 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Kristian Amlie
2011-04-01 06:01:25 PDT
Created attachment 87849 [details]
Install-correct-header-files-for-webkit
Created attachment 87850 [details]
Same-patch-with-whitespace-changes-removed
For easier reading, here is the same patch with all whitespace-only changes removed.
Anyone has any idea if this is correct? My knowledge of qmake magic is limited :( FYI, I will be away for the next two weeks, so I will not respond during that time. This seems like an easy review for a qt reviewer. I think you meant to obsolete the first patch and mark the second one for review/cq. Down-prioritize to P3 because the modularization project is a bit unknown state to us. We can revisit those patches after QtWebKit will find its way to Qt source tree. Comment on attachment 87849 [details]
Install-correct-header-files-for-webkit
r=me . Holding off the cq+ per Alexis' comment.
Why not removing the other references to QTDIR_build then? Comment on attachment 87849 [details] Install-correct-header-files-for-webkit Clearing flags on attachment: 87849 Committed r85870: <http://trac.webkit.org/changeset/85870> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/85870 might have broken GTK Linux 32-bit Debug The following tests are not passing: svg/W3C-SVG-1.1/animate-elem-46-t.svg Revision r85870 cherry-picked into qtwebkit-2.2 with commit b8f0053 <http://gitorious.org/webkit/qtwebkit/commit/b8f0053> |