Summary: | [GTK] Main loop sources are leaked in RunLoopGtk | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2011-04-01 05:39:36 PDT
Created attachment 87847 [details]
Patch
Patch to fix the leaks.
Comment on attachment 87847 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87847&action=review Great work. Please consider the method name changes below before landing. > Source/WebKit2/Platform/gtk/RunLoopGtk.cpp:95 > +void RunLoop::TimerBase::reset() I think the name clearTimerSource better describes what this one does. > Source/WebKit2/Platform/gtk/RunLoopGtk.cpp:100 > +void RunLoop::TimerBase::resetTimerSource(RunLoop::TimerBase* timer) Please call this one destroyNotifyCallback to make it clear that this is just used as a callback. > Source/WebKit2/Platform/gtk/RunLoopGtk.cpp:105 > +gboolean RunLoop::TimerBase::timerFired(RunLoop::TimerBase* timer) Please call this one timerFiredCallback. Committed r82805: <http://trac.webkit.org/changeset/82805> |