Bug 57614

Summary: ARIA Grid tables should return GridRole in roleValue() method
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: New BugsAssignee: Mario Sanchez Prada <mario>
Status: REOPENED    
Severity: Normal CC: abarth, cfleizach, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 57643    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Mario Sanchez Prada
Reported 2011-04-01 04:49:13 PDT
ARIA Grid tables should return GridRole in roleValue() method
Attachments
Patch (4.07 KB, patch)
2011-04-01 04:53 PDT, Mario Sanchez Prada 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mario Sanchez Prada
Comment 1 2011-04-01 04:53:43 PDT
Created attachment 87840 [details] Patch
Mario Sanchez Prada
Comment 2 2011-04-01 04:54:44 PDT
Added Chris to CC
chris fleizach
Comment 3 2011-04-01 08:58:28 PDT
Comment on attachment 87840 [details] Patch r=me
Mario Sanchez Prada
Comment 4 2011-04-01 09:16:16 PDT
Committed r82687: <http://trac.webkit.org/changeset/82687>
WebKit Review Bot
Comment 5 2011-04-01 10:29:17 PDT
http://trac.webkit.org/changeset/82687 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: platform/mac/accessibility/aria-treegrid.html
Mario Sanchez Prada
Comment 6 2011-04-01 10:41:51 PDT
Reopening, as current patch broke one test in the Mac bots: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r82689%20(27607)/platform/mac/accessibility ...seems like something else in the Mac code needs changing. Ideas?
chris fleizach
Comment 7 2011-04-01 10:55:51 PDT
i don't know. i'll have to apply the patch and figure out
Mario Sanchez Prada
Comment 8 2011-04-14 07:17:14 PDT
Comment on attachment 87840 [details] Patch Clearing flags. Not proposing anything yet since I found out that some more changes would be needed in the GTK port in order to keep working as expected (like checking GridRole's in places where only TableRole is checked at the moment), hence a Layout Test would also be needed so we can automate the detection for this kind of regressions.
Note You need to log in before you can comment on or make changes to this bug.