Summary: | WKCACFViewLayerTreeHost needs to tell WKCACFView where to render | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | New Bugs | Assignee: | Adam Roben (:aroben) <aroben> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, sullivan, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2011-03-31 10:20:51 PDT
Created attachment 87758 [details]
Patch
Attachment 87758 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 87758 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87758&action=review > Source/WebCore/ChangeLog:7 > + Fixes <http://webkit.org/b/57560> WKCACFViewLayerTreeHost needs to tell WKCACFView where to We need to teach the style checker about this alternate format for bug URLs. > Source/WebCore/platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:47 > + kWKCACFViewDrawingDestinationWindow = 0, > + kWKCACFViewDrawingDestinationImage = 1, Do we really need to set these values explicitly. Comment on attachment 87758 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87758&action=review >> Source/WebCore/ChangeLog:7 >> + Fixes <http://webkit.org/b/57560> WKCACFViewLayerTreeHost needs to tell WKCACFView where to > > We need to teach the style checker about this alternate format for bug URLs. I think the style checker recently got a lot more strict about how the URL appears in the ChangeLog. I think it knows about the shorter URL form, but doesn't accept URLs that are not on their own line. >> Source/WebCore/platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:47 >> + kWKCACFViewDrawingDestinationImage = 1, > > Do we really need to set these values explicitly. It seemed best to match the API header itself, which also sets those values. But I think we can get rid of the " = 1", which would leave us with just "= 0" on the first item. That would match how CF defines its enums. Committed r82608: <http://trac.webkit.org/changeset/82608> |