Bug 57550

Summary: Rename BidiResolver::lastBeforeET to m_lastBeforeET to match modern style
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2011-03-31 08:32:10 PDT
Rename BidiResolver::lastBeforeET to m_lastBeforeET to match modern style
Attachments
Patch (5.03 KB, patch)
2011-03-31 08:32 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-03-31 08:32:55 PDT
Created attachment 87731 [details] Patch
WebKit Commit Bot
Comment 2 2011-03-31 08:37:13 PDT
Comment on attachment 87731 [details] Patch Rejecting attachment 87731 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2 Last 500 characters of output: fs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/text/BidiResolver.h Hunk #1 FAILED at 213. Hunk #5 FAILED at 905. Hunk #6 FAILED at 951. Hunk #7 FAILED at 975. Hunk #8 FAILED at 990. 5 out of 8 hunks FAILED -- saving rejects to file Source/WebCore/platform/text/BidiResolver.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Ryosuke Niwa', u'--for..." exit_code: 1 Full output: http://queues.webkit.org/results/8309377
WebKit Commit Bot
Comment 3 2011-03-31 14:33:27 PDT
Comment on attachment 87731 [details] Patch Clearing flags on attachment: 87731 Committed r82618: <http://trac.webkit.org/changeset/82618>
WebKit Commit Bot
Comment 4 2011-03-31 14:33:32 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2011-03-31 15:15:34 PDT
http://trac.webkit.org/changeset/82618 might have broken Qt Linux Release
Note You need to log in before you can comment on or make changes to this bug.