Bug 57544

Summary:

Web Inspector: remove dots at the end of error messages

Product:

WebKit

Reporter:

Andrey Kosyakov <caseq>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Kosyakov <caseq>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, commit-queue, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none

Andrey Kosyakov

Reported 2011-03-31 07:01:29 PDT

Error messages we return may be used as a part of a larger formatted message, e.g. in parenthesis, before a colon or comma, having a dot at the end of error messages does not fit this use well.

Attachments
patch (11.16 KB, patch) 2011-03-31 07:25 PDT, Andrey Kosyakov	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrey Kosyakov

Comment 1 2011-03-31 07:25:25 PDT

Created attachment 87723 [details] patch for i in *.cpp; do sed 's/$errorString = ".*$\.";/\1";/' $i >$i.tmp && mv $i.tmp $i; done

WebKit Commit Bot

Comment 2 2011-03-31 08:21:49 PDT

Comment on attachment 87723 [details] patch Clearing flags on attachment: 87723 Committed r82581: <http://trac.webkit.org/changeset/82581>

WebKit Commit Bot

Comment 3 2011-03-31 08:21:54 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.