Bug 57505

Summary: getComputedStyle fails for 'first-line' pseudo-element
Product: WebKit Reporter: felix <felix8a>
Component: New BugsAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Normal CC: bugmail, jberlin, menard, mrowe, sam, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.6   
Attachments:
Description Flags
a.html
none
Patch
none
Patch for landing none

felix
Reported 2011-03-30 14:25:42 PDT
Created attachment 87615 [details] a.html the attached "a.html" prints the computed color of foo:first-char and foo:first-line. I expect both to have the same value. instead, getComputedStyle(foo, 'first-line') returns a style object where all the values are "".
Attachments
a.html (244 bytes, text/html)
2011-03-30 14:25 PDT, felix 		no flags
Details
Patch (6.07 KB, patch)
2012-02-28 03:05 PST, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.04 KB, patch)
2012-02-28 11:11 PST, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eli Grey (:sephr)
Comment 1 2011-11-24 21:21:33 PST
The second parameter to getComputedStyle in your testcase must include the colon. Also, it's :first-letter, not :first-char.
Eli Grey (:sephr)
Comment 2 2011-11-24 21:32:09 PST
It also appears that ::selection doesn't work either.
Eli Grey (:sephr)
Comment 3 2011-11-24 21:45:55 PST
Sorry to spam, but none of the ::-webkit-scrollbar stuff works either. This is essential for my dom2canvas webpage screenshot utility.
Alexis Menard (darktears)
Comment 4 2012-02-24 10:10:15 PST
<!doctype html> <body> <style> p:first-letter { color: red } </style> <div id="test"></div> <p id="foo">hello</p> <script> var foo = document.getElementById('foo'); var test = document.getElementById('test'); test.innerHTML = window.getComputedStyle(foo, ':first-letter').color </script> </body> works perfectly. (r108516).
Antonio Gomes
Comment 5 2012-02-24 17:16:22 PST
(In reply to comment #4) > <!doctype html> > <body> > <style> > p:first-letter { color: red } > </style> > <div id="test"></div> > <p id="foo">hello</p> > <script> > var foo = document.getElementById('foo'); > var test = document.getElementById('test'); > test.innerHTML = window.getComputedStyle(foo, ':first-letter').color > </script> > </body> > > works perfectly. (r108516). Quick question: ":first-letter" and ":first-line" are the same / work the same?
felix
Comment 6 2012-02-27 05:22:47 PST
Sorry for the typos in the a.html attachment. Here's a better example. This does what I expect in firefox, but not in safari or chrome: <!doctype html> <html> <body> <style> #a { color: red; } #b:first-letter { color: red; } </style> <p id="a">hello</p> <p id="b">world</p> <script> var a = document.getElementById('a'); var b = document.getElementById('b'); alert(window.getComputedStyle(a, ':first-letter').color + ':' + window.getComputedStyle(b, ':first-letter').color); </script> </body> </html> In firefox 11.0 it alerts 'rgb(255, 0, 0):rgb(255, 0, 0)' In safari 5.1.3 it alerts ':rgb(255, 0, 0)'
Alexis Menard (darktears)
Comment 7 2012-02-28 03:05:16 PST
Created attachment 129221 [details] Patch
Alexis Menard (darktears)
Comment 8 2012-02-28 03:08:21 PST
Comment on attachment 129221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129221&action=review > Source/WebCore/dom/Element.cpp:1671 > + } I will fix that later.
Tony Chang
Comment 9 2012-02-28 10:23:02 PST
Comment on attachment 129221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129221&action=review > Source/WebCore/ChangeLog:14 > + No new tests : I updated the expectation of one. Please name the test that you updated here. > LayoutTests/fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html:70 > - { 'elementId' : 'testNoPseudoElement', 'pseudoElement' : ':first-line', 'property' : 'color', 'expectedValue' : '' }, > + { 'elementId' : 'testNoPseudoElement', 'pseudoElement' : ':first-line', 'property' : 'color', 'expectedValue' : 'rgb(165, 42, 42)' }, Can we add test cases for more pseudo styles?
Alexis Menard (darktears)
Comment 10 2012-02-28 11:11:46 PST
Created attachment 129295 [details] Patch for landing
WebKit Review Bot
Comment 11 2012-02-28 11:55:54 PST
Comment on attachment 129295 [details] Patch for landing Clearing flags on attachment: 129295 Committed r109134: <http://trac.webkit.org/changeset/109134>
WebKit Review Bot
Comment 12 2012-02-28 11:55:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.