Bug 57493

Summary: Update fast/canvas tests to avoid dumping the render tree when possible
Product: WebKit Reporter: Matthew Delaney <mdelaney7>
Component: Tools / TestsAssignee: Matthew Delaney <mdelaney7>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch cmarrin: review+

Matthew Delaney
Reported 2011-03-30 11:55:54 PDT
New implementations of canvas require putting the canvas into its own layer. When a layout test doesn't dumpAsText and subsequently dumps the render tree, there may be different looking trees depending on which canvas implementation is used. Most (if not all) of the fast/canvas tests have no need to compare the render tree over just using dumpAsText, though most are best used as pixel tests. This patch will change all fast/canvas tests to use layoutTestController.dumpAsText(true) where the 'true' parameter allows for pixel results to also be generated. This solves both issues going forward.
Attachments
Patch (81.76 KB, patch)
2011-03-30 14:07 PDT, Matthew Delaney 		cmarrin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matthew Delaney
Comment 1 2011-03-30 14:07:44 PDT
Created attachment 87610 [details] Patch
Chris Marrin
Comment 2 2011-03-30 16:34:26 PDT
Comment on attachment 87610 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87610&action=review I see why you're trying to do this - to avoid differences in the expected results for the different versions. But that makes many of the expected results blank. How do you know if the test passed or failed? Normally you write something to the page to says this which gets put into the expected results. > LayoutTests/fast/canvas/canvas-transform-identity-expected.txt:1 > + I understand the motivation of getting rid of the tree. But shouldn't you at least put in pass/fail messages? What is this test doing? How do you know whether it passed or not? The same is true for results on several other tests here.
Matthew Delaney
Comment 3 2011-03-30 16:42:01 PDT
My understanding is that most of these tests are only useful as pixel tests since looking at the render tree and seeing a canvas inside of a div doesn't tell you anything anyway (for all these tests that draw something into the canvas, like shadows for example).
Chris Marrin
Comment 4 2011-03-30 16:49:38 PDT
Comment on attachment 87610 [details] Patch I see now that these have pixel results. So the expected results are fine.
Matthew Delaney
Comment 5 2011-03-30 17:01:05 PDT
Committed r82521: <http://trac.webkit.org/changeset/82521>
Note You need to log in before you can comment on or make changes to this bug.