Bug 57477

Summary: ASSERT(cookieStorageAdapter) when calling stopObservingCookieChanges after WebProcess has crashed
Product: WebKit Reporter: Brian Weinstein <bweinstein>
Component: WebKit2Assignee: Brian Weinstein <bweinstein>
Status: RESOLVED FIXED    
Severity: Normal CC: jberlin
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
[PATCH] Fix
none
[PATCH] Fix w/ early return + comment andersca: review+

Brian Weinstein
Reported 2011-03-30 10:56:04 PDT
If we have called CookieStorageMac::startObservingCookieChanges, and then the WebProcess crashes, the WebProcess will restart, and when we call stopObservingCookieChanges, cookieStorageAdapter won't have been initialized yet, and the ASSERT(cookieStorageAdapter) will fail. We don't need this assert, as it can be clearly incorrect, and there isn't harm in dispatching a message to nil if cookieStorageAdapter hasn't been defined yet. <rdar://problem/9178751>
Attachments
[PATCH] Fix (1.51 KB, patch)
2011-03-30 10:59 PDT, Brian Weinstein 		no flags
DetailsFormatted DiffDiff
[PATCH] Fix w/ early return + comment (1.76 KB, patch)
2011-03-30 11:06 PDT, Brian Weinstein 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brian Weinstein
Comment 1 2011-03-30 10:59:16 PDT
Created attachment 87575 [details] [PATCH] Fix
Jessie Berlin
Comment 2 2011-03-30 11:01:49 PDT
Comment on attachment 87575 [details] [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=87575&action=review > Source/WebCore/platform/network/mac/CookieStorageMac.mm:119 > [cookieStorageAdapter stopListeningForCookieChangeNotifications]; I know that dispatching a message to nil won't crash, but I think it is very unclear here that it is ok for the cookieStorageAdapter to be null. I think a comment and an early return would be better.
Brian Weinstein
Comment 3 2011-03-30 11:06:16 PDT
Created attachment 87576 [details] [PATCH] Fix w/ early return + comment
Jessie Berlin
Comment 4 2011-03-30 11:07:20 PDT
Comment on attachment 87576 [details] [PATCH] Fix w/ early return + comment Unofficially, as I am not a reviewer, r=me.
Brian Weinstein
Comment 5 2011-03-30 11:12:59 PDT
Landed in r82473.
Note You need to log in before you can comment on or make changes to this bug.