Bug 57454

Summary: Web Inspector: remove dead code from Script.js.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, domenic, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch. pfeldman: review+

Pavel Podivilov
Reported 2011-03-30 07:49:39 PDT
Web Inspector: remove dead code from Script.js.
Attachments
Patch. (5.30 KB, patch)
2011-03-30 07:50 PDT, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-03-30 07:50:11 PDT
Created attachment 87534 [details] Patch.
Pavel Podivilov
Comment 2 2011-04-01 03:57:27 PDT
Committed r82670: <http://trac.webkit.org/changeset/82670>
Domenic Denicola
Comment 3 2011-09-01 16:35:23 PDT
My team is working with an embedded instance of WebKit (Chromium branch, build 742) and we can't get the "//@ sourceURL" feature to work. After looking at the original commit linked to from http://pmuellr.blogspot.com/2009/06/debugger-friendly.html and tracing the removal of that code to here, we've hit a dead end. Since this is "dead code," where did sourceURL support go? Where can we look to see what's going wrong? Presumably sourceURL is still supported by WebKit, since it works fine in Chrome. So it must be something weird about our custom embedded instance, and we'd love some help debugging it. Thanks for your time, and hope this is an OK venue to ask for help.
Pavel Podivilov
Comment 4 2011-09-02 02:31:33 PDT
This code became dead when we stopped pushing script source to frontend to make loading faster. SourceURL values are now extracted on backend side by JS engine. It was implemented in V8 but not in JSC. There is a bug report opened for this - https://bugs.webkit.org/show_bug.cgi?id=65532.
Note You need to log in before you can comment on or make changes to this bug.