Bug 57451
| Summary: | [chromium] DumpRenderTree silently fails when command-line arg is missing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Evan Martin <evan> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | dglazkov, schenney, tkent |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Evan Martin
The code looks like:
=> params.testUrl = webkit_support::CreateURLForPathOrURL(pathOrURL);
webkit_support::SetCurrentDirectoryForFileURL(params.testUrl);
The first line converts a string like "foobar" into "file:///foobar".
We should instead test whether that file exists, and resolve it into "file:///absolute/path/to/foobar".
This means the changed CreateURLForPathOrURL() can potentially fail and abort.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Evan Martin
Sorry, to actually state the bug:
path/to/DumpRenderTree path/to/somefile
this silently fails, even when the file exists, because it really wants an absolute path. We should both absolutize the path and verify it exists.