Bug 57446

Summary: Web Inspector: [chromium] script formatting doesn't work when all scripts are concatenated.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch.
none
Fix style.
pfeldman: review-
Patch. pfeldman: review+

Pavel Podivilov
Reported 2011-03-30 06:05:39 PDT
Web Inspector: [chromium] script formatting doesn't work when all scripts are concatenated.
Attachments
Patch. (7.78 KB, patch)
2011-03-30 06:06 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Fix style. (7.74 KB, patch)
2011-03-30 06:52 PDT, Pavel Podivilov 		pfeldman: review-
DetailsFormatted DiffDiff
Patch. (8.11 KB, patch)
2011-03-30 09:14 PDT, Pavel Podivilov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-03-30 06:06:56 PDT
Created attachment 87514 [details] Patch. Inline script imports in worker script in release mode.
WebKit Review Bot
Comment 2 2011-03-30 06:09:30 PDT
Attachment 87514 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/chromium/scripts/inline_js_imports.py:42: expected 2 blank lines, found 1 [pep8/E302] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Pavel Podivilov
Comment 3 2011-03-30 06:52:35 PDT
Created attachment 87525 [details] Fix style.
Pavel Feldman
Comment 4 2011-03-30 08:24:49 PDT
Comment on attachment 87525 [details] Fix style. View in context: https://bugs.webkit.org/attachment.cgi?id=87525&action=review > Source/WebKit/chromium/WebKit.gyp:751 > + 'concatenated_script_formatter_worker_js', This is not enough to deploy this file. Also, where does inspector.js get concatenated for WebKit/Safari?
Pavel Podivilov
Comment 5 2011-03-30 09:14:00 PDT
Created attachment 87548 [details] Patch. Updated grd target.
Pavel Podivilov
Comment 6 2011-03-30 09:15:00 PDT
(In reply to comment #4) > (From update of attachment 87525 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=87525&action=review > > > Source/WebKit/chromium/WebKit.gyp:751 > > + 'concatenated_script_formatter_worker_js', > > This is not enough to deploy this file. Done. >Also, where does inspector.js get concatenated for WebKit/Safari? This change is targeted at chrome only.
Pavel Podivilov
Comment 7 2011-04-01 02:53:55 PDT
Committed r82666: <http://trac.webkit.org/changeset/82666>
Note You need to log in before you can comment on or make changes to this bug.