Bug 57420

Summary: [WinCairo] ENABLE(VIDEO) Broken
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: alex.christensen, commit-queue, eric.carlson, esprehn+autocc, glenn, jer.noble, kondapallykalyan, mrobinson, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch none

Description Brent Fulgham 2011-03-29 21:40:29 PDT 
It's been a long time since I built with ENABLE(VIDEO) active.  It turns out that a lot of CG-specific rendering code has crept into the Windows common routines, preventing WinCairo from building with other video support (e.g., GStreamer).

This bug tracks the correction of this problem.
Comment 1 Philippe Normand 2011-04-06 13:46:08 PDT 
It's been a while since last I played with VIDEO on WinCairo, but what are the specific issues you have?

WinCairo should use the ImageGStreamerCairo interface, just as GTK does. No CG stuff should  be involved :)
Comment 2 Alex Christensen 2013-11-12 09:15:47 PST 
Created attachment 216684 [details]
Patch
Comment 3 Philippe Normand 2013-11-12 09:25:09 PST 
Comment on attachment 216684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216684&action=review

> Source/WebCore/ChangeLog:3
> +        Preparation for GStreamer on Windows.

nit, this is not the right bug title
Comment 4 Alex Christensen 2013-11-12 10:21:41 PST 
committed in http://trac.webkit.org/changeset/159122 with the title "[WinCairo] Preparation for ENABLE(VIDEO)."
Comment 5 Philippe Normand 2014-03-03 00:17:45 PST 
So this bug can be closed then?
Comment 6 Alex Christensen 2014-03-03 08:56:12 PST 
Yep.  For some reason, I don't have access to close it, though.