Bug 57419 – Move factory-like things in EventDispatcher::dispatchMouseEvent to a factory, clean up names and ordering.

• Component: New Bugs
• Status: RESOLVED FIXED

[Dimitri Glazkov (Google)]

Move factory-like things in EventDispatcher::dispatchMouseEvent to a factory, clean up names and ordering.

[Dimitri Glazkov (Google)]

Created attachment 87463 [details]
Patch

[Dimitri Glazkov (Google)]

Created attachment 87545 [details]
Rebased against ToT.

[Darin Adler]

Comment on attachment 87545 [details]
Rebased against ToT.

View in context: https://bugs.webkit.org/attachment.cgi?id=87545&action=review

> Source/WebCore/dom/MouseEvent.cpp:33
> +PassRefPtr<MouseEvent> MouseEvent::create(const AtomicString& eventType, PassRefPtr<AbstractView> view, const PlatformMouseEvent& event, const IntPoint& position, int detail, PassRefPtr<Node> relatedTargetArg)

No need for arg in relatedTargetArg.

> Source/WebCore/dom/MouseEvent.cpp:35
> +    bool cancelable = eventType != eventNames().mousemoveEvent;

Change this to isCancelable instead of cancelable please.

> Source/WebCore/dom/MouseEvent.cpp:38
> +    return MouseEvent::create(eventType,
> +        true, cancelable, view,

Nitpickiest of nitpicks: I’d merge these two into one line.

> Source/WebCore/dom/MouseEvent.cpp:41
> +        relatedTargetArg,  0, false);

Extra space here.

> Source/WebCore/dom/MouseEvent.h:49
> +        static PassRefPtr<MouseEvent> create(const AtomicString& eventType, PassRefPtr<AbstractView>, const PlatformMouseEvent&, const IntPoint&, int detail, PassRefPtr<Node> relatedTargetArg);

No need for arg in relatedTargetArg.

[Dimitri Glazkov (Google)]

Thanks for review, Darin. Will fix and land.

[Dimitri Glazkov (Google)]

Committed r82501: <http://trac.webkit.org/changeset/82501>